Skip to content

Commit 6fa7db8

Browse files
iskaranthgregkh
authored andcommitted
staging: sm750fb: Add void to function definition with no arguments
Found by checkpatch.pl - ERROR: Bad function definition A function with no arguments allows for variadic arguments. Add void in between the empty parentheses to indicate that the function takes no arguments. changes made using coccinelle script: @@ type T; identifier f; @@ T f( +void ) { ... } Signed-off-by: Supriya Karanth <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent d6b0d6d commit 6fa7db8

File tree

6 files changed

+16
-16
lines changed

6 files changed

+16
-16
lines changed

drivers/staging/sm750fb/ddk750_chip.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ typedef struct _pllcalparam{
1111
pllcalparam;
1212

1313

14-
logical_chip_type_t getChipType()
14+
logical_chip_type_t getChipType(void)
1515
{
1616
unsigned short physicalID;
1717
char physicalRev;
@@ -91,7 +91,7 @@ unsigned int getPllValue(clock_type_t clockType, pll_value_t *pPLL)
9191
}
9292

9393

94-
unsigned int getChipClock()
94+
unsigned int getChipClock(void)
9595
{
9696
pll_value_t pll;
9797
#if 1
@@ -232,7 +232,7 @@ void setMasterClock(unsigned int frequency)
232232
}
233233

234234

235-
unsigned int ddk750_getVMSize()
235+
unsigned int ddk750_getVMSize(void)
236236
{
237237
unsigned int reg;
238238
unsigned int data;

drivers/staging/sm750fb/ddk750_display.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ void ddk750_setLogicalDispOut(disp_output_t output)
273273
}
274274

275275

276-
int ddk750_initDVIDisp()
276+
int ddk750_initDVIDisp(void)
277277
{
278278
/* Initialize DVI. If the dviInit fail and the VendorID or the DeviceID are
279279
not zeroed, then set the failure flag. If it is zeroe, it might mean

drivers/staging/sm750fb/ddk750_dvi.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ int dviInit(
6262
* Output:
6363
* Vendor ID
6464
*/
65-
unsigned short dviGetVendorID()
65+
unsigned short dviGetVendorID(void)
6666
{
6767
dvi_ctrl_device_t *pCurrentDviCtrl;
6868

@@ -82,7 +82,7 @@ unsigned short dviGetVendorID()
8282
* Output:
8383
* Device ID
8484
*/
85-
unsigned short dviGetDeviceID()
85+
unsigned short dviGetDeviceID(void)
8686
{
8787
dvi_ctrl_device_t *pCurrentDviCtrl;
8888

drivers/staging/sm750fb/ddk750_power.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ void ddk750_setDPMS(DPMS_t state)
1515
}
1616
}
1717

18-
unsigned int getPowerMode()
18+
unsigned int getPowerMode(void)
1919
{
2020
if(getChipType() == SM750LE)
2121
return 0;

drivers/staging/sm750fb/ddk750_sii164.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ static char *gDviCtrlChipName = "Silicon Image SiI 164";
3434
* Output:
3535
* Vendor ID
3636
*/
37-
unsigned short sii164GetVendorID()
37+
unsigned short sii164GetVendorID(void)
3838
{
3939
unsigned short vendorID;
4040

@@ -51,7 +51,7 @@ unsigned short sii164GetVendorID()
5151
* Output:
5252
* Device ID
5353
*/
54-
unsigned short sii164GetDeviceID()
54+
unsigned short sii164GetDeviceID(void)
5555
{
5656
unsigned short deviceID;
5757

@@ -264,7 +264,7 @@ long sii164InitChip(
264264
* sii164ResetChip
265265
* This function resets the DVI Controller Chip.
266266
*/
267-
void sii164ResetChip()
267+
void sii164ResetChip(void)
268268
{
269269
/* Power down */
270270
sii164SetPower(0);
@@ -277,7 +277,7 @@ void sii164ResetChip()
277277
* This function returns a char string name of the current DVI Controller chip.
278278
* It's convenient for application need to display the chip name.
279279
*/
280-
char *sii164GetChipString()
280+
char *sii164GetChipString(void)
281281
{
282282
return gDviCtrlChipName;
283283
}
@@ -375,7 +375,7 @@ void sii164EnableHotPlugDetection(
375375
* 0 - Not Connected
376376
* 1 - Connected
377377
*/
378-
unsigned char sii164IsConnected()
378+
unsigned char sii164IsConnected(void)
379379
{
380380
unsigned char hotPlugValue;
381381

@@ -394,7 +394,7 @@ unsigned char sii164IsConnected()
394394
* 0 - No interrupt
395395
* 1 - Interrupt occurs
396396
*/
397-
unsigned char sii164CheckInterrupt()
397+
unsigned char sii164CheckInterrupt(void)
398398
{
399399
unsigned char detectReg;
400400

@@ -409,7 +409,7 @@ unsigned char sii164CheckInterrupt()
409409
* sii164ClearInterrupt
410410
* Clear the hot plug interrupt.
411411
*/
412-
void sii164ClearInterrupt()
412+
void sii164ClearInterrupt(void)
413413
{
414414
unsigned char detectReg;
415415

drivers/staging/sm750fb/sm750_hw.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -581,7 +581,7 @@ void hw_sm750_initAccel(struct lynx_share * share)
581581
share->accel.de_init(&share->accel);
582582
}
583583

584-
int hw_sm750le_deWait()
584+
int hw_sm750le_deWait(void)
585585
{
586586
int i=0x10000000;
587587
while(i--){
@@ -598,7 +598,7 @@ int hw_sm750le_deWait()
598598
}
599599

600600

601-
int hw_sm750_deWait()
601+
int hw_sm750_deWait(void)
602602
{
603603
int i=0x10000000;
604604
while(i--){

0 commit comments

Comments
 (0)