remoteproc: fix off-by-one bug in __rproc_free_vrings

Subramaniam Chanderashekarapuram · ohadbc · commit 6fd98c124c66 · 2012-05-13T23:15:42.000+03:00
Fix a nasty off-by-one bug in __rproc_free_vrings which
resulted in a memory leak and (for some platforms) failures
to reload the remote processor.

Signed-off-by: Subramaniam Chanderashekarapuram &lt;subramaniam.ca@ti.com&gt;
[ohad@wizery.com: reword commit log, stick with the for loop]
Signed-off-by: Ohad Ben-Cohen &lt;ohad@wizery.com&gt;
diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
@@ -354,7 +354,7 @@ static void __rproc_free_vrings(struct rproc_vdev *rvdev, int i)
 {
 	struct rproc *rproc = rvdev->rproc;
 
-	for (i--; i > 0; i--) {
+	for (i--; i >= 0; i--) {
 		struct rproc_vring *rvring = &rvdev->vring[i];
 		int size = PAGE_ALIGN(vring_size(rvring->len, rvring->align));
 

Original file line number	Diff line number	Diff line change
`@@ -354,7 +354,7 @@ static void __rproc_free_vrings(struct rproc_vdev *rvdev, int i)`
`354`	`354`	`{`
`355`	`355`	`struct rproc *rproc = rvdev->rproc;`
`356`	`356`
`357`		`- for (i--; i > 0; i--) {`
	`357`	`+ for (i--; i >= 0; i--) {`
`358`	`358`	`struct rproc_vring *rvring = &rvdev->vring[i];`
`359`	`359`	`int size = PAGE_ALIGN(vring_size(rvring->len, rvring->align));`
`360`	`360`