Skip to content

Commit 7008701

Browse files
jwboyerMatt Fleming
authored andcommitted
x86, efi: Don't map Boot Services on i386
Add patch to fix 32bit EFI service mapping (rhbz 726701) Multiple people are reporting hitting the following WARNING on i386, WARNING: at arch/x86/mm/ioremap.c:102 __ioremap_caller+0x3d3/0x440() Modules linked in: Pid: 0, comm: swapper Not tainted 3.9.0-rc7+ #95 Call Trace: [<c102b6af>] warn_slowpath_common+0x5f/0x80 [<c1023fb3>] ? __ioremap_caller+0x3d3/0x440 [<c1023fb3>] ? __ioremap_caller+0x3d3/0x440 [<c102b6ed>] warn_slowpath_null+0x1d/0x20 [<c1023fb3>] __ioremap_caller+0x3d3/0x440 [<c106007b>] ? get_usage_chars+0xfb/0x110 [<c102d937>] ? vprintk_emit+0x147/0x480 [<c1418593>] ? efi_enter_virtual_mode+0x1e4/0x3de [<c102406a>] ioremap_cache+0x1a/0x20 [<c1418593>] ? efi_enter_virtual_mode+0x1e4/0x3de [<c1418593>] efi_enter_virtual_mode+0x1e4/0x3de [<c1407984>] start_kernel+0x286/0x2f4 [<c1407535>] ? repair_env_string+0x51/0x51 [<c1407362>] i386_start_kernel+0x12c/0x12f Due to the workaround described in commit 916f676 ("x86, efi: Retain boot service code until after switching to virtual mode") EFI Boot Service regions are mapped for a period during boot. Unfortunately, with the limited size of the i386 direct kernel map it's possible that some of the Boot Service regions will not be directly accessible, which causes them to be ioremap()'d, triggering the above warning as the regions are marked as E820_RAM in the e820 memmap. There are currently only two situations where we need to map EFI Boot Service regions, 1. To workaround the firmware bug described in 916f676 2. To access the ACPI BGRT image but since we haven't seen an i386 implementation that requires either, this simple fix should suffice for now. [ Added to changelog - Matt ] Reported-by: Bryan O'Donoghue <[email protected]> Acked-by: Tom Zanussi <[email protected]> Acked-by: Darren Hart <[email protected]> Cc: Josh Triplett <[email protected]> Cc: Matthew Garrett <[email protected]> Cc: H. Peter Anvin <[email protected]> Cc: Ingo Molnar <[email protected]> Cc: Thomas Gleixner <[email protected]> Cc: Greg Kroah-Hartman <[email protected]> Cc: <[email protected]> Signed-off-by: Josh Boyer <[email protected]> Signed-off-by: Matt Fleming <[email protected]>
1 parent 272b98c commit 7008701

File tree

1 file changed

+7
-4
lines changed
  • arch/x86/platform/efi

1 file changed

+7
-4
lines changed

arch/x86/platform/efi/efi.c

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -912,10 +912,13 @@ void __init efi_enter_virtual_mode(void)
912912

913913
for (p = memmap.map; p < memmap.map_end; p += memmap.desc_size) {
914914
md = p;
915-
if (!(md->attribute & EFI_MEMORY_RUNTIME) &&
916-
md->type != EFI_BOOT_SERVICES_CODE &&
917-
md->type != EFI_BOOT_SERVICES_DATA)
918-
continue;
915+
if (!(md->attribute & EFI_MEMORY_RUNTIME)) {
916+
#ifdef CONFIG_X86_64
917+
if (md->type != EFI_BOOT_SERVICES_CODE &&
918+
md->type != EFI_BOOT_SERVICES_DATA)
919+
#endif
920+
continue;
921+
}
919922

920923
size = md->num_pages << EFI_PAGE_SHIFT;
921924
end = md->phys_addr + size;

0 commit comments

Comments
 (0)