Skip to content

Commit 713c43b

Browse files
jpirkodavem330
authored andcommitted
mlxsw: spectrum_flower: Remove bogus warns in mlxsw_sp_flower_destroy
This warnings may be hit even in case they should not - in case user puts a TC-flower rule which failed to be offloaded. So just remove them. Reported-by: Petr Machata <[email protected]> Reported-by: Ido Schimmel <[email protected]> Fixes: commit 7aa0f5a ("mlxsw: spectrum: Implement TC flower offload") Signed-off-by: Jiri Pirko <[email protected]> Acked-by: Ido Schimmel <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent f7887d4 commit 713c43b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -303,11 +303,11 @@ void mlxsw_sp_flower_destroy(struct mlxsw_sp_port *mlxsw_sp_port, bool ingress,
303303
ruleset = mlxsw_sp_acl_ruleset_get(mlxsw_sp, mlxsw_sp_port->dev,
304304
ingress,
305305
MLXSW_SP_ACL_PROFILE_FLOWER);
306-
if (WARN_ON(IS_ERR(ruleset)))
306+
if (IS_ERR(ruleset))
307307
return;
308308

309309
rule = mlxsw_sp_acl_rule_lookup(mlxsw_sp, ruleset, f->cookie);
310-
if (!WARN_ON(!rule)) {
310+
if (rule) {
311311
mlxsw_sp_acl_rule_del(mlxsw_sp, rule);
312312
mlxsw_sp_acl_rule_destroy(mlxsw_sp, rule);
313313
}

0 commit comments

Comments
 (0)