Skip to content

Commit 714710e

Browse files
dtorJason Cooper
authored andcommitted
irqchip: bcm7120-l2: Fix error handling of irq_of_parse_and_map
Return value of irq_of_parse_and_map() is unsigned int, with 0 indicating failure, so testing for negative result never works. Signed-off-by: Dmitry Torokhov <[email protected]> Acked-by: Florian Fainelli <[email protected]> Tested-by: Kevin Cernekee <[email protected]> Link: https://lkml.kernel.org/r/20141114221614.GA37395@dtor-ws Signed-off-by: Jason Cooper <[email protected]>
1 parent 45977fe commit 714710e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/irqchip/irq-bcm7120-l2.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,9 +101,9 @@ static int bcm7120_l2_intc_init_one(struct device_node *dn,
101101
int parent_irq;
102102

103103
parent_irq = irq_of_parse_and_map(dn, irq);
104-
if (parent_irq < 0) {
104+
if (!parent_irq) {
105105
pr_err("failed to map interrupt %d\n", irq);
106-
return parent_irq;
106+
return -EINVAL;
107107
}
108108

109109
data->irq_map_mask |= be32_to_cpup(map_mask + irq);

0 commit comments

Comments
 (0)