mlxsw: core: remove an unnecessary condition

Dan Carpenter · davem330 · commit 719255d0e294 · 2016-01-06T15:07:47.000-05:00
We checked "err" on the lines before so we know it's zero here.

These cause a static checker warning because checking known things can
indicate a bug.  Maybe there is a missing assignment or we are checking
the wrong variable.

Signed-off-by: Dan Carpenter &lt;dan.carpenter@oracle.com&gt;
Acked-by: Jiri Pirko &lt;jiri@mellanox.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/ethernet/mellanox/mlxsw/core_hwmon.c b/drivers/net/ethernet/mellanox/mlxsw/core_hwmon.c
@@ -130,7 +130,7 @@ static ssize_t mlxsw_hwmon_temp_rst_store(struct device *dev,
 		dev_err(mlxsw_hwmon->bus_info->dev, "Failed to reset temp sensor history\n");
 		return err;
 	}
-	return err ? err : len;
+	return len;
 }
 
 static ssize_t mlxsw_hwmon_fan_rpm_show(struct device *dev,

Original file line number	Diff line number	Diff line change
`@@ -130,7 +130,7 @@ static ssize_t mlxsw_hwmon_temp_rst_store(struct device *dev,`
`130`	`130`	`dev_err(mlxsw_hwmon->bus_info->dev, "Failed to reset temp sensor history\n");`
`131`	`131`	`return err;`
`132`	`132`	`}`
`133`		`- return err ? err : len;`
	`133`	`+ return len;`
`134`	`134`	`}`
`135`	`135`
`136`	`136`	`static ssize_t mlxsw_hwmon_fan_rpm_show(struct device *dev,`