net: marvell: prestera: uninitialized variable bug

Dan Carpenter · kuba-moo · commit 71930846b36f · 2022-07-29T20:27:39.000-07:00
The "ret" variable needs to be initialized at the start. Fixes: 52323ef ("net: marvell: prestera: add phylink support") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Link: https://lore.kernel.org/r/YuKeBBuGtsmd7QdT@kili Signed-off-by: Jakub Kicinski <kuba@kernel.org>
diff --git a/drivers/net/ethernet/marvell/prestera/prestera_main.c b/drivers/net/ethernet/marvell/prestera/prestera_main.c
@@ -847,7 +847,7 @@ static void prestera_event_handlers_unregister(struct prestera_switch *sw)
 static int prestera_switch_set_base_mac_addr(struct prestera_switch *sw)
 {
 	struct device_node *base_mac_np;
-	int ret;
+	int ret = 0;
 
 	if (sw->np) {
 		base_mac_np = of_parse_phandle(sw->np, "base-mac-provider", 0);

Original file line number	Diff line number	Diff line change
`@@ -847,7 +847,7 @@ static void prestera_event_handlers_unregister(struct prestera_switch *sw)`
`847`	`847`	`static int prestera_switch_set_base_mac_addr(struct prestera_switch *sw)`
`848`	`848`	`{`
`849`	`849`	`struct device_node *base_mac_np;`
`850`		`- int ret;`
	`850`	`+ int ret = 0;`
`851`	`851`
`852`	`852`	`if (sw->np) {`
`853`	`853`	`base_mac_np = of_parse_phandle(sw->np, "base-mac-provider", 0);`