Skip to content

Commit 72578c3

Browse files
committed
ext4: unify handling of mount options which have been removed
Signed-off-by: "Theodore Ts'o" <[email protected]>
1 parent 39ef17f commit 72578c3

File tree

1 file changed

+8
-20
lines changed

1 file changed

+8
-20
lines changed

fs/ext4/super.c

Lines changed: 8 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1332,9 +1332,9 @@ static const struct export_operations ext4_export_ops = {
13321332
enum {
13331333
Opt_bsd_df, Opt_minix_df, Opt_grpid, Opt_nogrpid,
13341334
Opt_resgid, Opt_resuid, Opt_sb, Opt_err_cont, Opt_err_panic, Opt_err_ro,
1335-
Opt_nouid32, Opt_debug, Opt_oldalloc, Opt_orlov,
1335+
Opt_nouid32, Opt_debug, Opt_removed,
13361336
Opt_user_xattr, Opt_nouser_xattr, Opt_acl, Opt_noacl,
1337-
Opt_auto_da_alloc, Opt_noauto_da_alloc, Opt_noload, Opt_nobh, Opt_bh,
1337+
Opt_auto_da_alloc, Opt_noauto_da_alloc, Opt_noload,
13381338
Opt_commit, Opt_min_batch_time, Opt_max_batch_time,
13391339
Opt_journal_dev, Opt_journal_checksum, Opt_journal_async_commit,
13401340
Opt_abort, Opt_data_journal, Opt_data_ordered, Opt_data_writeback,
@@ -1365,16 +1365,16 @@ static const match_table_t tokens = {
13651365
{Opt_err_ro, "errors=remount-ro"},
13661366
{Opt_nouid32, "nouid32"},
13671367
{Opt_debug, "debug"},
1368-
{Opt_oldalloc, "oldalloc"},
1369-
{Opt_orlov, "orlov"},
1368+
{Opt_removed, "oldalloc"},
1369+
{Opt_removed, "orlov"},
13701370
{Opt_user_xattr, "user_xattr"},
13711371
{Opt_nouser_xattr, "nouser_xattr"},
13721372
{Opt_acl, "acl"},
13731373
{Opt_noacl, "noacl"},
13741374
{Opt_noload, "noload"},
13751375
{Opt_noload, "norecovery"},
1376-
{Opt_nobh, "nobh"},
1377-
{Opt_bh, "bh"},
1376+
{Opt_removed, "nobh"},
1377+
{Opt_removed, "bh"},
13781378
{Opt_commit, "commit=%u"},
13791379
{Opt_min_batch_time, "min_batch_time=%u"},
13801380
{Opt_max_batch_time, "max_batch_time=%u"},
@@ -1582,13 +1582,9 @@ static int parse_options(char *options, struct super_block *sb,
15821582
case Opt_debug:
15831583
set_opt(sb, DEBUG);
15841584
break;
1585-
case Opt_oldalloc:
1585+
case Opt_removed:
15861586
ext4_msg(sb, KERN_WARNING,
1587-
"Ignoring deprecated oldalloc option");
1588-
break;
1589-
case Opt_orlov:
1590-
ext4_msg(sb, KERN_WARNING,
1591-
"Ignoring deprecated orlov option");
1587+
"Ignoring deprecated %s option", p);
15921588
break;
15931589
#ifdef CONFIG_EXT4_FS_XATTR
15941590
case Opt_user_xattr:
@@ -1781,14 +1777,6 @@ static int parse_options(char *options, struct super_block *sb,
17811777
else
17821778
clear_opt(sb, BARRIER);
17831779
break;
1784-
case Opt_nobh:
1785-
ext4_msg(sb, KERN_WARNING,
1786-
"Ignoring deprecated nobh option");
1787-
break;
1788-
case Opt_bh:
1789-
ext4_msg(sb, KERN_WARNING,
1790-
"Ignoring deprecated bh option");
1791-
break;
17921780
case Opt_i_version:
17931781
sb->s_flags |= MS_I_VERSION;
17941782
break;

0 commit comments

Comments
 (0)