Skip to content

Commit 730b2ad

Browse files
Sibi Sankarandersson
authored andcommitted
remoteproc: fix null pointer dereference on glink only platforms
Currently calling list_del on smd subdev remove path results in null pointer dereference on glink only platforms. Fix this by adding safety checks in glink/smd subdev remove paths. Signed-off-by: Sibi Sankar <[email protected]> Signed-off-by: Bjorn Andersson <[email protected]>
1 parent dea4bd1 commit 730b2ad

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

drivers/remoteproc/qcom_common.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,9 @@ EXPORT_SYMBOL_GPL(qcom_add_glink_subdev);
7575
*/
7676
void qcom_remove_glink_subdev(struct rproc *rproc, struct qcom_rproc_glink *glink)
7777
{
78+
if (!glink->node)
79+
return;
80+
7881
rproc_remove_subdev(rproc, &glink->subdev);
7982
of_node_put(glink->node);
8083
}
@@ -165,6 +168,9 @@ EXPORT_SYMBOL_GPL(qcom_add_smd_subdev);
165168
*/
166169
void qcom_remove_smd_subdev(struct rproc *rproc, struct qcom_rproc_subdev *smd)
167170
{
171+
if (!smd->node)
172+
return;
173+
168174
rproc_remove_subdev(rproc, &smd->subdev);
169175
of_node_put(smd->node);
170176
}

0 commit comments

Comments
 (0)