Skip to content

Commit 739fd94

Browse files
Wolfgang Kufnerlinvjw
authored andcommitted
rt2x00: Pad beacon to multiple of 32 bits.
Pad beacon to a multiple of 32 bits in preparation for the change from memcpy_toio() to __iowrite32_copy() in register_multiwrite(). Signed-off-by: Wolfgang Kufner <[email protected]> Acked-by: Helmut Schaa <[email protected]> Signed-off-by: Ivo van Doorn <[email protected]> Signed-off-by: John W. Linville <[email protected]>
1 parent e85b4c0 commit 739fd94

File tree

3 files changed

+18
-8
lines changed

3 files changed

+18
-8
lines changed

drivers/net/wireless/rt2x00/rt2800lib.c

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -772,6 +772,7 @@ void rt2800_write_beacon(struct queue_entry *entry, struct txentry_desc *txdesc)
772772
struct rt2x00_dev *rt2x00dev = entry->queue->rt2x00dev;
773773
struct skb_frame_desc *skbdesc = get_skb_frame_desc(entry->skb);
774774
unsigned int beacon_base;
775+
unsigned int padding_len;
775776
u32 reg;
776777

777778
/*
@@ -806,11 +807,13 @@ void rt2800_write_beacon(struct queue_entry *entry, struct txentry_desc *txdesc)
806807
rt2x00debug_dump_frame(rt2x00dev, DUMP_FRAME_BEACON, entry->skb);
807808

808809
/*
809-
* Write entire beacon with TXWI to register.
810+
* Write entire beacon with TXWI and padding to register.
810811
*/
812+
padding_len = roundup(entry->skb->len, 4) - entry->skb->len;
813+
skb_pad(entry->skb, padding_len);
811814
beacon_base = HW_BEACON_OFFSET(entry->entry_idx);
812-
rt2800_register_multiwrite(rt2x00dev, beacon_base,
813-
entry->skb->data, entry->skb->len);
815+
rt2800_register_multiwrite(rt2x00dev, beacon_base, entry->skb->data,
816+
entry->skb->len + padding_len);
814817

815818
/*
816819
* Enable beaconing again.

drivers/net/wireless/rt2x00/rt61pci.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1961,6 +1961,7 @@ static void rt61pci_write_beacon(struct queue_entry *entry,
19611961
struct rt2x00_dev *rt2x00dev = entry->queue->rt2x00dev;
19621962
struct queue_entry_priv_pci *entry_priv = entry->priv_data;
19631963
unsigned int beacon_base;
1964+
unsigned int padding_len;
19641965
u32 reg;
19651966

19661967
/*
@@ -1982,13 +1983,16 @@ static void rt61pci_write_beacon(struct queue_entry *entry,
19821983
rt2x00debug_dump_frame(rt2x00dev, DUMP_FRAME_BEACON, entry->skb);
19831984

19841985
/*
1985-
* Write entire beacon with descriptor to register.
1986+
* Write entire beacon with descriptor and padding to register.
19861987
*/
1988+
padding_len = roundup(entry->skb->len, 4) - entry->skb->len;
1989+
skb_pad(entry->skb, padding_len);
19871990
beacon_base = HW_BEACON_OFFSET(entry->entry_idx);
19881991
rt2x00pci_register_multiwrite(rt2x00dev, beacon_base,
19891992
entry_priv->desc, TXINFO_SIZE);
19901993
rt2x00pci_register_multiwrite(rt2x00dev, beacon_base + TXINFO_SIZE,
1991-
entry->skb->data, entry->skb->len);
1994+
entry->skb->data,
1995+
entry->skb->len + padding_len);
19921996

19931997
/*
19941998
* Enable beaconing again.

drivers/net/wireless/rt2x00/rt73usb.c

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1546,6 +1546,7 @@ static void rt73usb_write_beacon(struct queue_entry *entry,
15461546
{
15471547
struct rt2x00_dev *rt2x00dev = entry->queue->rt2x00dev;
15481548
unsigned int beacon_base;
1549+
unsigned int padding_len;
15491550
u32 reg;
15501551

15511552
/*
@@ -1573,11 +1574,13 @@ static void rt73usb_write_beacon(struct queue_entry *entry,
15731574
rt2x00debug_dump_frame(rt2x00dev, DUMP_FRAME_BEACON, entry->skb);
15741575

15751576
/*
1576-
* Write entire beacon with descriptor to register.
1577+
* Write entire beacon with descriptor and padding to register.
15771578
*/
1579+
padding_len = roundup(entry->skb->len, 4) - entry->skb->len;
1580+
skb_pad(entry->skb, padding_len);
15781581
beacon_base = HW_BEACON_OFFSET(entry->entry_idx);
1579-
rt2x00usb_register_multiwrite(rt2x00dev, beacon_base,
1580-
entry->skb->data, entry->skb->len);
1582+
rt2x00usb_register_multiwrite(rt2x00dev, beacon_base, entry->skb->data,
1583+
entry->skb->len + padding_len);
15811584

15821585
/*
15831586
* Enable beaconing again.

0 commit comments

Comments
 (0)