Skip to content

Commit 73a6d94

Browse files
tang-chenbonzini
authored andcommitted
kvm: Use APIC_DEFAULT_PHYS_BASE macro as the apic access page address.
We have APIC_DEFAULT_PHYS_BASE defined as 0xfee00000, which is also the address of apic access page. So use this macro. Signed-off-by: Tang Chen <[email protected]> Reviewed-by: Gleb Natapov <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
1 parent 2c69c1a commit 73a6d94

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

arch/x86/kvm/svm.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1257,7 +1257,8 @@ static struct kvm_vcpu *svm_create_vcpu(struct kvm *kvm, unsigned int id)
12571257
svm->asid_generation = 0;
12581258
init_vmcb(svm);
12591259

1260-
svm->vcpu.arch.apic_base = 0xfee00000 | MSR_IA32_APICBASE_ENABLE;
1260+
svm->vcpu.arch.apic_base = APIC_DEFAULT_PHYS_BASE |
1261+
MSR_IA32_APICBASE_ENABLE;
12611262
if (kvm_vcpu_is_bsp(&svm->vcpu))
12621263
svm->vcpu.arch.apic_base |= MSR_IA32_APICBASE_BSP;
12631264

arch/x86/kvm/vmx.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4023,13 +4023,13 @@ static int alloc_apic_access_page(struct kvm *kvm)
40234023
goto out;
40244024
kvm_userspace_mem.slot = APIC_ACCESS_PAGE_PRIVATE_MEMSLOT;
40254025
kvm_userspace_mem.flags = 0;
4026-
kvm_userspace_mem.guest_phys_addr = 0xfee00000ULL;
4026+
kvm_userspace_mem.guest_phys_addr = APIC_DEFAULT_PHYS_BASE;
40274027
kvm_userspace_mem.memory_size = PAGE_SIZE;
40284028
r = __kvm_set_memory_region(kvm, &kvm_userspace_mem);
40294029
if (r)
40304030
goto out;
40314031

4032-
page = gfn_to_page(kvm, 0xfee00);
4032+
page = gfn_to_page(kvm, APIC_DEFAULT_PHYS_BASE >> PAGE_SHIFT);
40334033
if (is_error_page(page)) {
40344034
r = -EFAULT;
40354035
goto out;
@@ -4502,7 +4502,7 @@ static void vmx_vcpu_reset(struct kvm_vcpu *vcpu)
45024502

45034503
vmx->vcpu.arch.regs[VCPU_REGS_RDX] = get_rdx_init_val();
45044504
kvm_set_cr8(&vmx->vcpu, 0);
4505-
apic_base_msr.data = 0xfee00000 | MSR_IA32_APICBASE_ENABLE;
4505+
apic_base_msr.data = APIC_DEFAULT_PHYS_BASE | MSR_IA32_APICBASE_ENABLE;
45064506
if (kvm_vcpu_is_bsp(&vmx->vcpu))
45074507
apic_base_msr.data |= MSR_IA32_APICBASE_BSP;
45084508
apic_base_msr.host_initiated = true;

0 commit comments

Comments
 (0)