Skip to content

Commit 74a2594

Browse files
tobluxgroeck
authored andcommitted
hwmon: (asus_atk0110) Use str_enabled_disabled() and str_enable_disable() helpers
Remove hard-coded strings by using the str_enabled_disabled() and str_enable_disable() helper functions. Signed-off-by: Thorsten Blum <[email protected]> Link: https://lore.kernel.org/r/[email protected] [groeck: Fixed subject and continuation line alignments] Signed-off-by: Guenter Roeck <[email protected]>
1 parent c8571ea commit 74a2594

File tree

1 file changed

+6
-9
lines changed

1 file changed

+6
-9
lines changed

drivers/hwmon/asus_atk0110.c

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
#include <linux/jiffies.h>
1818
#include <linux/err.h>
1919
#include <linux/acpi.h>
20+
#include <linux/string_choices.h>
2021

2122
#define ATK_HID "ATK0110"
2223

@@ -441,7 +442,7 @@ static void atk_print_sensor(struct atk_data *data, union acpi_object *obj)
441442
flags->integer.value,
442443
name->string.pointer,
443444
limit1->integer.value, limit2->integer.value,
444-
enable->integer.value ? "enabled" : "disabled");
445+
str_enabled_disabled(enable->integer.value));
445446
#endif
446447
}
447448

@@ -1074,8 +1075,7 @@ static int atk_ec_enabled(struct atk_data *data)
10741075
err = -EIO;
10751076
} else {
10761077
err = (buf->value != 0);
1077-
dev_dbg(dev, "EC is %sabled\n",
1078-
err ? "en" : "dis");
1078+
dev_dbg(dev, "EC is %s\n", str_enabled_disabled(err));
10791079
}
10801080

10811081
ACPI_FREE(obj);
@@ -1096,18 +1096,15 @@ static int atk_ec_ctl(struct atk_data *data, int enable)
10961096

10971097
obj = atk_sitm(data, &sitm);
10981098
if (IS_ERR(obj)) {
1099-
dev_err(dev, "Failed to %sable the EC\n",
1100-
enable ? "en" : "dis");
1099+
dev_err(dev, "Failed to %s the EC\n", str_enable_disable(enable));
11011100
return PTR_ERR(obj);
11021101
}
11031102
ec_ret = (struct atk_acpi_ret_buffer *)obj->buffer.pointer;
11041103
if (ec_ret->flags == 0) {
1105-
dev_err(dev, "Failed to %sable the EC\n",
1106-
enable ? "en" : "dis");
1104+
dev_err(dev, "Failed to %s the EC\n", str_enable_disable(enable));
11071105
err = -EIO;
11081106
} else {
1109-
dev_info(dev, "EC %sabled\n",
1110-
enable ? "en" : "dis");
1107+
dev_info(dev, "EC %s\n", str_enabled_disabled(enable));
11111108
}
11121109

11131110
ACPI_FREE(obj);

0 commit comments

Comments
 (0)