Skip to content

Commit 7526ff7

Browse files
Hollis Blanchardpaulusmack
authored andcommitted
powerpc: Remove superfluous WARN_ON() from dma-noncoherent.c
I can't tell why this WARN_ON exists, and there's no comment explaining it. Whether the pmd is present or not, pte_alloc_kernel() seems to handle both cases. Booting a 440 kernel with 64K PAGE_SIZE triggers the warning, but boot successfully completes and I see no problems beyond that. Signed-off-by: Hollis Blanchard <[email protected]> Acked-by: Benjamin Herrenschmidt <[email protected]> Signed-off-by: Paul Mackerras <[email protected]>
1 parent efc3624 commit 7526ff7

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

arch/powerpc/lib/dma-noncoherent.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -320,7 +320,6 @@ static int __init dma_alloc_init(void)
320320
ret = -ENOMEM;
321321
break;
322322
}
323-
WARN_ON(!pmd_none(*pmd));
324323

325324
pte = pte_alloc_kernel(pmd, CONSISTENT_BASE);
326325
if (!pte) {

0 commit comments

Comments
 (0)