Skip to content

Commit 7546a38

Browse files
Ander Conselvan de Oliveiradanvet
authored andcommitted
drm/i915: Update comment in clear_intel_crtc_state()
Explain why a few fields of the new pipe_config have their values preserved, while the others are zeroed. Signed-off-by: Ander Conselvan de Oliveira <[email protected]> Signed-off-by: Daniel Vetter <[email protected]>
1 parent b88baa2 commit 7546a38

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

drivers/gpu/drm/i915/intel_display.c

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11485,7 +11485,11 @@ clear_intel_crtc_state(struct intel_crtc_state *crtc_state)
1148511485
enum intel_dpll_id shared_dpll;
1148611486
uint32_t ddi_pll_sel;
1148711487

11488-
/* Clear only the intel specific part of the crtc state excluding scalers */
11488+
/* FIXME: before the switch to atomic started, a new pipe_config was
11489+
* kzalloc'd. Code that depends on any field being zero should be
11490+
* fixed, so that the crtc_state can be safely duplicated. For now,
11491+
* only fields that are know to not cause problems are preserved. */
11492+
1148911493
tmp_state = crtc_state->base;
1149011494
scaler_state = crtc_state->scaler_state;
1149111495
shared_dpll = crtc_state->shared_dpll;

0 commit comments

Comments
 (0)