Skip to content

Commit 758581b

Browse files
Dolev RavivChristoph Hellwig
authored andcommitted
scsi: ufs: fix static checker warning in ufshcd_populate_vreg
This patch fixes newly introduced static checker warning in ufshcd_populate_vreg, introduced by UFS power management series. Warning: drivers/scsi/ufs/ufshcd-pltfrm.c:167 ufshcd_populate_vreg() warn: missing error code here? 'devm_kzalloc()' failed. 'ret' = '0' To fix it we return -ENOMEM and skip the message print. Signed-off-by: Dolev Raviv <[email protected]> Reviewed-by: Maya Erez <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
1 parent 233b594 commit 758581b

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

drivers/scsi/ufs/ufshcd-pltfrm.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -162,10 +162,8 @@ static int ufshcd_populate_vreg(struct device *dev, const char *name,
162162
}
163163

164164
vreg = devm_kzalloc(dev, sizeof(*vreg), GFP_KERNEL);
165-
if (!vreg) {
166-
dev_err(dev, "No memory for %s regulator\n", name);
167-
goto out;
168-
}
165+
if (!vreg)
166+
return -ENOMEM;
169167

170168
vreg->name = kstrdup(name, GFP_KERNEL);
171169

0 commit comments

Comments
 (0)