Skip to content

Commit 75d79b8

Browse files
bvanasschedledford
authored andcommitted
RDMA/srpt: Join split strings
Make sure that long strings occur on a single line as required by the coding standard. Cc: Sergey Gorenko <[email protected]> Cc: Max Gurtovoy <[email protected]> Cc: Laurence Oberman <[email protected]> Signed-off-by: Bart Van Assche <[email protected]> Signed-off-by: Doug Ledford <[email protected]>
1 parent ffd5980 commit 75d79b8

File tree

1 file changed

+12
-17
lines changed

1 file changed

+12
-17
lines changed

drivers/infiniband/ulp/srpt/ib_srpt.c

Lines changed: 12 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,7 @@ static int srpt_get_u64_x(char *buffer, const struct kernel_param *kp)
8989
module_param_call(srpt_service_guid, NULL, srpt_get_u64_x, &srpt_service_guid,
9090
0444);
9191
MODULE_PARM_DESC(srpt_service_guid,
92-
"Using this value for ioc_guid, id_ext, and cm_listen_id"
93-
" instead of using the node_guid of the first HCA.");
92+
"Using this value for ioc_guid, id_ext, and cm_listen_id instead of using the node_guid of the first HCA.");
9493

9594
static struct ib_client srpt_client;
9695
/* Protects both rdma_cm_port and rdma_cm_id. */
@@ -1037,8 +1036,7 @@ static int srpt_get_desc_tbl(struct srpt_send_ioctx *ioctx,
10371036

10381037
if (nbufs >
10391038
(srp_cmd->data_out_desc_cnt + srp_cmd->data_in_desc_cnt)) {
1040-
pr_err("received unsupported SRP_CMD request"
1041-
" type (%u out + %u in != %u / %zu)\n",
1039+
pr_err("received unsupported SRP_CMD request type (%u out + %u in != %u / %zu)\n",
10421040
srp_cmd->data_out_desc_cnt,
10431041
srp_cmd->data_in_desc_cnt,
10441042
be32_to_cpu(idb->table_desc.len),
@@ -1352,8 +1350,8 @@ static int srpt_build_cmd_rsp(struct srpt_rdma_ch *ch,
13521350
BUILD_BUG_ON(MIN_MAX_RSP_SIZE <= sizeof(*srp_rsp));
13531351
max_sense_len = ch->max_ti_iu_len - sizeof(*srp_rsp);
13541352
if (sense_data_len > max_sense_len) {
1355-
pr_warn("truncated sense data from %d to %d"
1356-
" bytes\n", sense_data_len, max_sense_len);
1353+
pr_warn("truncated sense data from %d to %d bytes\n",
1354+
sense_data_len, max_sense_len);
13571355
sense_data_len = max_sense_len;
13581356
}
13591357

@@ -1693,14 +1691,14 @@ static void srpt_send_done(struct ib_cq *cq, struct ib_wc *wc)
16931691
atomic_add(1 + ioctx->n_rdma, &ch->sq_wr_avail);
16941692

16951693
if (wc->status != IB_WC_SUCCESS)
1696-
pr_info("sending response for ioctx 0x%p failed"
1697-
" with status %d\n", ioctx, wc->status);
1694+
pr_info("sending response for ioctx 0x%p failed with status %d\n",
1695+
ioctx, wc->status);
16981696

16991697
if (state != SRPT_STATE_DONE) {
17001698
transport_generic_free_cmd(&ioctx->cmd, 0);
17011699
} else {
1702-
pr_err("IB completion has been received too late for"
1703-
" wr_id = %u.\n", ioctx->ioctx.index);
1700+
pr_err("IB completion has been received too late for wr_id = %u.\n",
1701+
ioctx->ioctx.index);
17041702
}
17051703

17061704
srpt_process_wait_list(ch);
@@ -3023,9 +3021,8 @@ static void srpt_add_one(struct ib_device *device)
30233021
}
30243022

30253023
/* print out target login information */
3026-
pr_debug("Target login info: id_ext=%016llx,ioc_guid=%016llx,"
3027-
"pkey=ffff,service_id=%016llx\n", srpt_service_guid,
3028-
srpt_service_guid, srpt_service_guid);
3024+
pr_debug("Target login info: id_ext=%016llx,ioc_guid=%016llx,pkey=ffff,service_id=%016llx\n",
3025+
srpt_service_guid, srpt_service_guid, srpt_service_guid);
30293026

30303027
/*
30313028
* We do not have a consistent service_id (ie. also id_ext of target_id)
@@ -3738,16 +3735,14 @@ static int __init srpt_init_module(void)
37383735

37393736
ret = -EINVAL;
37403737
if (srp_max_req_size < MIN_MAX_REQ_SIZE) {
3741-
pr_err("invalid value %d for kernel module parameter"
3742-
" srp_max_req_size -- must be at least %d.\n",
3738+
pr_err("invalid value %d for kernel module parameter srp_max_req_size -- must be at least %d.\n",
37433739
srp_max_req_size, MIN_MAX_REQ_SIZE);
37443740
goto out;
37453741
}
37463742

37473743
if (srpt_srq_size < MIN_SRPT_SRQ_SIZE
37483744
|| srpt_srq_size > MAX_SRPT_SRQ_SIZE) {
3749-
pr_err("invalid value %d for kernel module parameter"
3750-
" srpt_srq_size -- must be in the range [%d..%d].\n",
3745+
pr_err("invalid value %d for kernel module parameter srpt_srq_size -- must be in the range [%d..%d].\n",
37513746
srpt_srq_size, MIN_SRPT_SRQ_SIZE, MAX_SRPT_SRQ_SIZE);
37523747
goto out;
37533748
}

0 commit comments

Comments
 (0)