Skip to content

Commit 75fd4fe

Browse files
jmberg-intellucacoelho
authored andcommitted
iwlwifi: mvm: fix error checking for multi/broadcast sta
The earlier patch called the station add functions but didn't assign their return value to the ret variable, so that the checks for it were meaningless. Fix that. Found by smatch: .../mac80211.c:2560 iwl_mvm_start_ap_ibss() warn: we tested 'ret' before and it was 'false' .../mac80211.c:2563 iwl_mvm_start_ap_ibss() warn: we tested 'ret' before and it was 'false' Fixes: 3a89411cd31c ("iwlwifi: mvm: fix assert 0x2B00 on older FWs") Signed-off-by: Johannes Berg <[email protected]> Signed-off-by: Luca Coelho <[email protected]>
1 parent e829b17 commit 75fd4fe

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2132,10 +2132,10 @@ static int iwl_mvm_start_ap_ibss(struct ieee80211_hw *hw,
21322132
* Send the bcast station. At this stage the TBTT and DTIM time
21332133
* events are added and applied to the scheduler
21342134
*/
2135-
iwl_mvm_send_add_bcast_sta(mvm, vif);
2135+
ret = iwl_mvm_send_add_bcast_sta(mvm, vif);
21362136
if (ret)
21372137
goto out_unbind;
2138-
iwl_mvm_add_mcast_sta(mvm, vif);
2138+
ret = iwl_mvm_add_mcast_sta(mvm, vif);
21392139
if (ret) {
21402140
iwl_mvm_send_rm_bcast_sta(mvm, vif);
21412141
goto out_unbind;

0 commit comments

Comments
 (0)