Skip to content

Commit 762df10

Browse files
anjutsudhakarmpe
authored andcommitted
powerpc/kprobes: Optimize kprobe in kretprobe_trampoline()
Kprobe placed on the kretprobe_trampoline() during boot time can be optimized, since the instruction at probe point is a 'nop'. Signed-off-by: Anju T Sudhakar <[email protected]> Acked-by: Masami Hiramatsu <[email protected]> Signed-off-by: Michael Ellerman <[email protected]>
1 parent 51c9c08 commit 762df10

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

arch/powerpc/kernel/kprobes.c

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -285,6 +285,7 @@ asm(".global kretprobe_trampoline\n"
285285
".type kretprobe_trampoline, @function\n"
286286
"kretprobe_trampoline:\n"
287287
"nop\n"
288+
"blr\n"
288289
".size kretprobe_trampoline, .-kretprobe_trampoline\n");
289290

290291
/*
@@ -337,6 +338,13 @@ static int __kprobes trampoline_probe_handler(struct kprobe *p,
337338

338339
kretprobe_assert(ri, orig_ret_address, trampoline_address);
339340
regs->nip = orig_ret_address;
341+
/*
342+
* Make LR point to the orig_ret_address.
343+
* When the 'nop' inside the kretprobe_trampoline
344+
* is optimized, we can do a 'blr' after executing the
345+
* detour buffer code.
346+
*/
347+
regs->link = orig_ret_address;
340348

341349
reset_current_kprobe();
342350
kretprobe_hash_unlock(current, &flags);

arch/powerpc/kernel/optprobes.c

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,12 +72,11 @@ static unsigned long can_optimize(struct kprobe *p)
7272

7373
/*
7474
* kprobe placed for kretprobe during boot time
75-
* is not optimizing now.
76-
*
77-
* TODO: Optimize kprobe in kretprobe_trampoline
75+
* has a 'nop' instruction, which can be emulated.
76+
* So further checks can be skipped.
7877
*/
7978
if (p->addr == (kprobe_opcode_t *)&kretprobe_trampoline)
80-
return 0;
79+
return (unsigned long)p->addr + sizeof(kprobe_opcode_t);
8180

8281
/*
8382
* We only support optimizing kernel addresses, but not

0 commit comments

Comments
 (0)