Skip to content

Commit 77c4cf1

Browse files
committed
Merge tag 'md/3.16-fixes' of git://neil.brown.name/md
Pull md bugfixes from Neil Brown: "Two minor bugfixes for md in 3.16" * tag 'md/3.16-fixes' of git://neil.brown.name/md: md: flush writes before starting a recovery. md: make sure GET_ARRAY_INFO ioctl reports correct "clean" status
2 parents 88b5a85 + 133d452 commit 77c4cf1

File tree

1 file changed

+14
-1
lines changed

1 file changed

+14
-1
lines changed

drivers/md/md.c

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5599,7 +5599,7 @@ static int get_array_info(struct mddev * mddev, void __user * arg)
55995599
if (mddev->in_sync)
56005600
info.state = (1<<MD_SB_CLEAN);
56015601
if (mddev->bitmap && mddev->bitmap_info.offset)
5602-
info.state = (1<<MD_SB_BITMAP_PRESENT);
5602+
info.state |= (1<<MD_SB_BITMAP_PRESENT);
56035603
info.active_disks = insync;
56045604
info.working_disks = working;
56055605
info.failed_disks = failed;
@@ -7501,6 +7501,19 @@ void md_do_sync(struct md_thread *thread)
75017501
rdev->recovery_offset < j)
75027502
j = rdev->recovery_offset;
75037503
rcu_read_unlock();
7504+
7505+
/* If there is a bitmap, we need to make sure all
7506+
* writes that started before we added a spare
7507+
* complete before we start doing a recovery.
7508+
* Otherwise the write might complete and (via
7509+
* bitmap_endwrite) set a bit in the bitmap after the
7510+
* recovery has checked that bit and skipped that
7511+
* region.
7512+
*/
7513+
if (mddev->bitmap) {
7514+
mddev->pers->quiesce(mddev, 1);
7515+
mddev->pers->quiesce(mddev, 0);
7516+
}
75047517
}
75057518

75067519
printk(KERN_INFO "md: %s of RAID array %s\n", desc, mdname(mddev));

0 commit comments

Comments
 (0)