xfrm: Fix xfrm_state_migrate leak

spellingmistake · davem330 · commit 78347c8c6b2d · 2010-12-09T20:35:27.000-08:00
xfrm_state_migrate calls kfree instead of xfrm_state_put to free a failed state. According to git commit 553f911 this can cause memory leaks. Signed-off-by: Thomas Egerer <thomas.egerer@secunet.com> Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com> Acked-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c
@@ -1268,7 +1268,7 @@ struct xfrm_state * xfrm_state_migrate(struct xfrm_state *x,
 
 	return xc;
 error:
-	kfree(xc);
+	xfrm_state_put(xc);
 	return NULL;
 }
 EXPORT_SYMBOL(xfrm_state_migrate);

Original file line number	Diff line number	Diff line change
`@@ -1268,7 +1268,7 @@ struct xfrm_state * xfrm_state_migrate(struct xfrm_state *x,`
`1268`	`1268`
`1269`	`1269`	`return xc;`
`1270`	`1270`	`error:`
`1271`		`- kfree(xc);`
	`1271`	`+ xfrm_state_put(xc);`
`1272`	`1272`	`return NULL;`
`1273`	`1273`	`}`
`1274`	`1274`	`EXPORT_SYMBOL(xfrm_state_migrate);`