Skip to content

Commit 7968ca8

Browse files
heicarstMartin Schwidefsky
authored andcommitted
[S390] irq: simple coding style change
Use braces for if/else/list_for_each_entry bodies if the body consists of more than a single line. Otherwise I get confused and check if there is something broken whenever I see these code snippets. Signed-off-by: Heiko Carstens <[email protected]> Signed-off-by: Martin Schwidefsky <[email protected]>
1 parent ac2ac6e commit 7968ca8

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

arch/s390/kernel/irq.c

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -118,9 +118,10 @@ asmlinkage void do_softirq(void)
118118
"a" (__do_softirq)
119119
: "0", "1", "2", "3", "4", "5", "14",
120120
"cc", "memory" );
121-
} else
121+
} else {
122122
/* We are already on the async stack. */
123123
__do_softirq();
124+
}
124125
}
125126

126127
local_irq_restore(flags);
@@ -192,11 +193,12 @@ int unregister_external_interrupt(u16 code, ext_int_handler_t handler)
192193
int index = ext_hash(code);
193194

194195
spin_lock_irqsave(&ext_int_hash_lock, flags);
195-
list_for_each_entry_rcu(p, &ext_int_hash[index], entry)
196+
list_for_each_entry_rcu(p, &ext_int_hash[index], entry) {
196197
if (p->code == code && p->handler == handler) {
197198
list_del_rcu(&p->entry);
198199
kfree_rcu(p, rcu);
199200
}
201+
}
200202
spin_unlock_irqrestore(&ext_int_hash_lock, flags);
201203
return 0;
202204
}
@@ -211,9 +213,10 @@ void __irq_entry do_extint(struct pt_regs *regs, struct ext_code ext_code,
211213

212214
old_regs = set_irq_regs(regs);
213215
irq_enter();
214-
if (S390_lowcore.int_clock >= S390_lowcore.clock_comparator)
216+
if (S390_lowcore.int_clock >= S390_lowcore.clock_comparator) {
215217
/* Serve timer interrupts first. */
216218
clock_comparator_work();
219+
}
217220
kstat_cpu(smp_processor_id()).irqs[EXTERNAL_INTERRUPT]++;
218221
if (ext_code.code != 0x1004)
219222
__get_cpu_var(s390_idle).nohz_delay = 1;

0 commit comments

Comments
 (0)