Skip to content

Commit 7a4af4b

Browse files
committed
platform/x86: touchscreen_dmi: Remove the Glavey TM800A550L entry
The Glavey TM800A550L tablet is a tablet which ships with Android as factory OS. As such it has the typical broken DSDT which x86 Android tablets tend to have. Specifically the touchscreen ACPI device node is missing the IRQ for the touchscreen. So far users were expected to fix this with a DSDT overlay, but support for the TM800A550L has been added to the new x86-android-modules kernel-module and that will now automatically instantiate a proper i2c-client with the IRQ set for the touchscreen, including the necessary device-properties for the firmware loading. This means that the touchscreen_dmi entry for the TM800A550L is no longer necessary (and it no longer matches either since the touchscreen is no longer enumerated through ACPI), remove it. Signed-off-by: Hans de Goede <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent bfe9217 commit 7a4af4b

File tree

1 file changed

+0
-21
lines changed

1 file changed

+0
-21
lines changed

drivers/platform/x86/touchscreen_dmi.c

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -361,18 +361,6 @@ static const struct ts_dmi_data gdix1001_01_upside_down_data = {
361361
.properties = gdix1001_upside_down_props,
362362
};
363363

364-
static const struct property_entry glavey_tm800a550l_props[] = {
365-
PROPERTY_ENTRY_STRING("firmware-name", "gt912-glavey-tm800a550l.fw"),
366-
PROPERTY_ENTRY_STRING("goodix,config-name", "gt912-glavey-tm800a550l.cfg"),
367-
PROPERTY_ENTRY_U32("goodix,main-clk", 54),
368-
{ }
369-
};
370-
371-
static const struct ts_dmi_data glavey_tm800a550l_data = {
372-
.acpi_name = "GDIX1001:00",
373-
.properties = glavey_tm800a550l_props,
374-
};
375-
376364
static const struct property_entry gp_electronic_t701_props[] = {
377365
PROPERTY_ENTRY_U32("touchscreen-size-x", 960),
378366
PROPERTY_ENTRY_U32("touchscreen-size-y", 640),
@@ -1149,15 +1137,6 @@ const struct dmi_system_id touchscreen_dmi_table[] = {
11491137
DMI_MATCH(DMI_PRODUCT_NAME, "eSTAR BEAUTY HD Intel Quad core"),
11501138
},
11511139
},
1152-
{ /* Glavey TM800A550L */
1153-
.driver_data = (void *)&glavey_tm800a550l_data,
1154-
.matches = {
1155-
DMI_MATCH(DMI_BOARD_VENDOR, "AMI Corporation"),
1156-
DMI_MATCH(DMI_BOARD_NAME, "Aptio CRB"),
1157-
/* Above strings are too generic, also match on BIOS version */
1158-
DMI_MATCH(DMI_BIOS_VERSION, "ZY-8-BI-PX4S70VTR400-X423B-005-D"),
1159-
},
1160-
},
11611140
{
11621141
/* GP-electronic T701 */
11631142
.driver_data = (void *)&gp_electronic_t701_data,

0 commit comments

Comments
 (0)