Skip to content

Commit 7a72edd

Browse files
Ondrej Zarydavem330
authored andcommitted
tlan: Don't disable internal PHY on cards that use it in 10 Mbps mode
In tlan_reset_adapter, we disable internal PHY when an external one is used. On cards which use internal PHY in 10 Mbps mode, we enable it later when setting 10 Mbps mode but it does not really work (PHY fails to reset). Leave it enabled instead. Signed-off-by: Ondrej Zary <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 9cff441 commit 7a72edd

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

drivers/net/ethernet/ti/tlan.c

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2237,7 +2237,9 @@ tlan_reset_adapter(struct net_device *dev)
22372237
}
22382238
}
22392239

2240-
if (priv->phy_num == 0)
2240+
/* don't power down internal PHY if we're going to use it */
2241+
if (priv->phy_num == 0 ||
2242+
(priv->adapter->flags & TLAN_ADAPTER_USE_INTERN_10))
22412243
data |= TLAN_NET_CFG_PHY_EN;
22422244
tlan_dio_write16(dev->base_addr, TLAN_NET_CONFIG, (u16) data);
22432245

@@ -2688,7 +2690,6 @@ static void tlan_phy_finish_auto_neg(struct net_device *dev)
26882690
struct tlan_priv *priv = netdev_priv(dev);
26892691
u16 an_adv;
26902692
u16 an_lpa;
2691-
u16 data;
26922693
u16 mode;
26932694
u16 phy;
26942695
u16 status;
@@ -2721,9 +2722,6 @@ static void tlan_phy_finish_auto_neg(struct net_device *dev)
27212722
(priv->adapter->flags & TLAN_ADAPTER_USE_INTERN_10) &&
27222723
(priv->phy_num != 0)) {
27232724
priv->phy_num = 0;
2724-
data = TLAN_NET_CFG_1FRAG | TLAN_NET_CFG_1CHAN
2725-
| TLAN_NET_CFG_PHY_EN;
2726-
tlan_dio_write16(dev->base_addr, TLAN_NET_CONFIG, data);
27272725
tlan_set_timer(dev, (400*HZ/1000), TLAN_TIMER_PHY_PDOWN);
27282726
return;
27292727
}

0 commit comments

Comments
 (0)