Skip to content

Commit 7aa5038

Browse files
Binary-EaterSaeed Mahameed
authored andcommitted
net/mlx5e: Fix SQ wake logic in ptp napi_poll context
Check in the mlx5e_ptp_poll_ts_cq context if the ptp tx sq should be woken up. Before change, the ptp tx sq may never wake up if the ptp tx ts skb fifo is full when mlx5e_poll_tx_cq checks if the queue should be woken up. Fixes: 1880bc4 ("net/mlx5e: Add TX port timestamp support") Signed-off-by: Rahul Rameshbabu <[email protected]> Reviewed-by: Tariq Toukan <[email protected]> Signed-off-by: Saeed Mahameed <[email protected]>
1 parent 691c041 commit 7aa5038

File tree

3 files changed

+16
-7
lines changed

3 files changed

+16
-7
lines changed

drivers/net/ethernet/mellanox/mlx5/core/en/ptp.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -175,6 +175,8 @@ static bool mlx5e_ptp_poll_ts_cq(struct mlx5e_cq *cq, int budget)
175175
/* ensure cq space is freed before enabling more cqes */
176176
wmb();
177177

178+
mlx5e_txqsq_wake(&ptpsq->txqsq);
179+
178180
return work_done == budget;
179181
}
180182

drivers/net/ethernet/mellanox/mlx5/core/en/txrx.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -193,6 +193,8 @@ static inline u16 mlx5e_txqsq_get_next_pi(struct mlx5e_txqsq *sq, u16 size)
193193
return pi;
194194
}
195195

196+
void mlx5e_txqsq_wake(struct mlx5e_txqsq *sq);
197+
196198
static inline u16 mlx5e_shampo_get_cqe_header_index(struct mlx5e_rq *rq, struct mlx5_cqe64 *cqe)
197199
{
198200
return be16_to_cpu(cqe->shampo.header_entry_index) & (rq->mpwqe.shampo->hd_per_wq - 1);

drivers/net/ethernet/mellanox/mlx5/core/en_tx.c

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -762,6 +762,17 @@ static void mlx5e_tx_wi_consume_fifo_skbs(struct mlx5e_txqsq *sq, struct mlx5e_t
762762
}
763763
}
764764

765+
void mlx5e_txqsq_wake(struct mlx5e_txqsq *sq)
766+
{
767+
if (netif_tx_queue_stopped(sq->txq) &&
768+
mlx5e_wqc_has_room_for(&sq->wq, sq->cc, sq->pc, sq->stop_room) &&
769+
mlx5e_ptpsq_fifo_has_room(sq) &&
770+
!test_bit(MLX5E_SQ_STATE_RECOVERING, &sq->state)) {
771+
netif_tx_wake_queue(sq->txq);
772+
sq->stats->wake++;
773+
}
774+
}
775+
765776
bool mlx5e_poll_tx_cq(struct mlx5e_cq *cq, int napi_budget)
766777
{
767778
struct mlx5e_sq_stats *stats;
@@ -861,13 +872,7 @@ bool mlx5e_poll_tx_cq(struct mlx5e_cq *cq, int napi_budget)
861872

862873
netdev_tx_completed_queue(sq->txq, npkts, nbytes);
863874

864-
if (netif_tx_queue_stopped(sq->txq) &&
865-
mlx5e_wqc_has_room_for(&sq->wq, sq->cc, sq->pc, sq->stop_room) &&
866-
mlx5e_ptpsq_fifo_has_room(sq) &&
867-
!test_bit(MLX5E_SQ_STATE_RECOVERING, &sq->state)) {
868-
netif_tx_wake_queue(sq->txq);
869-
stats->wake++;
870-
}
875+
mlx5e_txqsq_wake(sq);
871876

872877
return (i == MLX5E_TX_CQ_POLL_BUDGET);
873878
}

0 commit comments

Comments
 (0)