Skip to content

Commit 7b21ad5

Browse files
Bang NguyenMukesh Kacker
authored andcommitted
rds: Fix regression in dynamic active bonding configuration
OraBug: 18481645 Commit 6cf7cc30 "rds: dynamic active bonding configuration" introduced a regression. Late joining IB interfaces were not configured correctly. When active bonding configuration shows both interfaces down, IP failover was not happening. This patch fixes this issue. Signed-off-by: Bang Nguyen <[email protected]> Signed-off-by: Ajaykumar Hotchandani <[email protected]> (cherry picked from commit 12755dbf7b4adc8ea2a935900b81c384731f6fff) Signed-off-by: Jerry Snitselaar <[email protected]> (cherry picked from commit 12eebc4)
1 parent 7efbd57 commit 7b21ad5

File tree

1 file changed

+5
-9
lines changed

1 file changed

+5
-9
lines changed

net/rds/ib.c

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1032,14 +1032,8 @@ static void rds_ib_failback(struct work_struct *_work)
10321032
u8 i, ip_active_port, port = work->port;
10331033

10341034
if (ip_config[port].port_state == RDS_IB_PORT_INIT) {
1035-
printk(KERN_NOTICE "RDS/IB: %s/port_%d/%s is ERROR\n",
1036-
ip_config[port].rds_ibdev->dev->name,
1037-
ip_config[port].port_num,
1038-
ip_config[port].if_name);
1039-
1040-
rds_ib_do_failover(port, 0, 0, work->event_type);
1041-
if (ip_config[port].ip_active_port != port)
1042-
ip_config[port].port_state = RDS_IB_PORT_DOWN;
1035+
ip_config[port].port_state = RDS_IB_PORT_UP;
1036+
ip_config[port].ip_active_port = port;
10431037
goto out;
10441038
}
10451039

@@ -1195,7 +1189,9 @@ static void rds_ib_dump_ip_config(void)
11951189
NIPQUAD(ip_config[i].ip_bcast),
11961190
NIPQUAD(ip_config[i].ip_mask),
11971191
(ip_config[i].port_state ==
1198-
RDS_IB_PORT_UP ? "UP" : "DOWN"));
1192+
RDS_IB_PORT_UP ? "UP" :
1193+
(ip_config[i].port_state ==
1194+
RDS_IB_PORT_DOWN ? "DOWN" : "INIT")));
11991195

12001196
for (j = 0; j < ip_config[i].alias_cnt; j++) {
12011197
printk(KERN_INFO "Alias %s "

0 commit comments

Comments
 (0)