Skip to content

Commit 7cf7d42

Browse files
committed
Merge tag 'for-linus-20150516' of git://git.infradead.org/linux-mtd
Pull MTD fixes from Brian Norris: "Two MTD fixes for 4.1: - readtest: the signal-handling code was clobbering the error codes we should be handling/reporting in this test, rendering it useless. Noticed by Coverity. - the common SPI NOR flash DT binding (merged for 4.1-rc1) is being revised, so let's change that before 4.1 is minted" * tag 'for-linus-20150516' of git://git.infradead.org/linux-mtd: Documentation: dt: mtd: replace "nor-jedec" binding with "jedec, spi-nor" mtd: readtest: don't clobber error reports
2 parents c0655fe + 8947e39 commit 7cf7d42

File tree

3 files changed

+10
-8
lines changed

3 files changed

+10
-8
lines changed

Documentation/devicetree/bindings/mtd/m25p80.txt renamed to Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ Required properties:
88
is not Linux-only, but in case of Linux, see the "m25p_ids"
99
table in drivers/mtd/devices/m25p80.c for the list of supported
1010
chips.
11-
Must also include "nor-jedec" for any SPI NOR flash that can be
12-
identified by the JEDEC READ ID opcode (0x9F).
11+
Must also include "jedec,spi-nor" for any SPI NOR flash that can
12+
be identified by the JEDEC READ ID opcode (0x9F).
1313
- reg : Chip-Select number
1414
- spi-max-frequency : Maximum frequency of the SPI bus the chip can operate at
1515

@@ -25,7 +25,7 @@ Example:
2525
flash: m25p80@0 {
2626
#address-cells = <1>;
2727
#size-cells = <1>;
28-
compatible = "spansion,m25p80", "nor-jedec";
28+
compatible = "spansion,m25p80", "jedec,spi-nor";
2929
reg = <0>;
3030
spi-max-frequency = <40000000>;
3131
m25p,fast-read;

drivers/mtd/devices/m25p80.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ static int m25p_probe(struct spi_device *spi)
223223
*/
224224
if (data && data->type)
225225
flash_name = data->type;
226-
else if (!strcmp(spi->modalias, "nor-jedec"))
226+
else if (!strcmp(spi->modalias, "spi-nor"))
227227
flash_name = NULL; /* auto-detect */
228228
else
229229
flash_name = spi->modalias;
@@ -255,7 +255,7 @@ static int m25p_remove(struct spi_device *spi)
255255
* since most of these flash are compatible to some extent, and their
256256
* differences can often be differentiated by the JEDEC read-ID command, we
257257
* encourage new users to add support to the spi-nor library, and simply bind
258-
* against a generic string here (e.g., "nor-jedec").
258+
* against a generic string here (e.g., "jedec,spi-nor").
259259
*
260260
* Many flash names are kept here in this list (as well as in spi-nor.c) to
261261
* keep them available as module aliases for existing platforms.
@@ -305,7 +305,7 @@ static const struct spi_device_id m25p_ids[] = {
305305
* Generic support for SPI NOR that can be identified by the JEDEC READ
306306
* ID opcode (0x9F). Use this, if possible.
307307
*/
308-
{"nor-jedec"},
308+
{"spi-nor"},
309309
{ },
310310
};
311311
MODULE_DEVICE_TABLE(spi, m25p_ids);

drivers/mtd/tests/readtest.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -191,9 +191,11 @@ static int __init mtd_readtest_init(void)
191191
err = ret;
192192
}
193193

194-
err = mtdtest_relax();
195-
if (err)
194+
ret = mtdtest_relax();
195+
if (ret) {
196+
err = ret;
196197
goto out;
198+
}
197199
}
198200

199201
if (err)

0 commit comments

Comments
 (0)