Skip to content

Commit 7db57e7

Browse files
committed
powerpc/spe: Mark expected switch fall-throughs
Mark switch cases where we are expecting to fall through. Fixes errors such as below, seen with mpc85xx_defconfig: arch/powerpc/kernel/align.c: In function 'emulate_spe': arch/powerpc/kernel/align.c:178:8: error: this statement may fall through ret |= __get_user_inatomic(temp.v[3], p++); ^~ Signed-off-by: Michael Ellerman <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent da1115f commit 7db57e7

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

arch/powerpc/kernel/align.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -176,9 +176,11 @@ static int emulate_spe(struct pt_regs *regs, unsigned int reg,
176176
ret |= __get_user_inatomic(temp.v[1], p++);
177177
ret |= __get_user_inatomic(temp.v[2], p++);
178178
ret |= __get_user_inatomic(temp.v[3], p++);
179+
/* fall through */
179180
case 4:
180181
ret |= __get_user_inatomic(temp.v[4], p++);
181182
ret |= __get_user_inatomic(temp.v[5], p++);
183+
/* fall through */
182184
case 2:
183185
ret |= __get_user_inatomic(temp.v[6], p++);
184186
ret |= __get_user_inatomic(temp.v[7], p++);
@@ -259,9 +261,11 @@ static int emulate_spe(struct pt_regs *regs, unsigned int reg,
259261
ret |= __put_user_inatomic(data.v[1], p++);
260262
ret |= __put_user_inatomic(data.v[2], p++);
261263
ret |= __put_user_inatomic(data.v[3], p++);
264+
/* fall through */
262265
case 4:
263266
ret |= __put_user_inatomic(data.v[4], p++);
264267
ret |= __put_user_inatomic(data.v[5], p++);
268+
/* fall through */
265269
case 2:
266270
ret |= __put_user_inatomic(data.v[6], p++);
267271
ret |= __put_user_inatomic(data.v[7], p++);

0 commit comments

Comments
 (0)