Skip to content

Commit 7de05cb

Browse files
NeerajSanjayKaleVudentz
authored andcommitted
Bluetooth: btnxpuart: Remove check for CTS low after FW download
This removes the unnecessary check for CTS low after FW download. After FW download is complete, the CTS line is already seen low. It becomes high after 2 msec, and low again after FW initialization is complete. This makes the current check for CTS low redundant. This removes the wait for CTS low section and increase delay to 1200msec instead, which is sufficiant for all NXP chipsets to initialize FW. Signed-off-by: Neeraj Sanjay Kale <[email protected]> Signed-off-by: Luiz Augusto von Dentz <[email protected]>
1 parent 59da988 commit 7de05cb

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

drivers/bluetooth/btnxpuart.c

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -558,16 +558,11 @@ static int nxp_download_firmware(struct hci_dev *hdev)
558558
}
559559

560560
serdev_device_set_flow_control(nxpdev->serdev, true);
561-
err = serdev_device_wait_for_cts(nxpdev->serdev, 1, 60000);
562-
if (err < 0) {
563-
bt_dev_err(hdev, "CTS is still high. FW Download failed.");
564-
return err;
565-
}
566561
release_firmware(nxpdev->fw);
567562
memset(nxpdev->fw_name, 0, sizeof(nxpdev->fw_name));
568563

569564
/* Allow the downloaded FW to initialize */
570-
usleep_range(800 * USEC_PER_MSEC, 1 * USEC_PER_SEC);
565+
msleep(1200);
571566

572567
return 0;
573568
}

0 commit comments

Comments
 (0)