Skip to content

Commit 7e381ec

Browse files
tombatmlind
authored andcommitted
ARM: dts: am57xx-beagle-x15: set VDD_SD to always-on
LDO1 regulator (VDD_SD) is connected to SoC's vddshv8. vddshv8 needs to be kept always powered (see commit 5a0f93c ("ARM: dts: Add am57xx-beagle-x15"), but at the moment VDD_SD is enabled/disabled depending on whether an SD card is inserted or not. This patch sets LDO1 regulator to always-on. This patch has a side effect of fixing another issue, HDMI DDC not working when SD card is not inserted: Why this happens is that the tpd12s015 (HDMI level shifter/ESD protection chip) has LS_OE GPIO input, which needs to be enabled for the HDMI DDC to work. LS_OE comes from gpio6_28. The pin that provides gpio6_28 is powered by vddshv8, and vddshv8 comes from VDD_SD. So when SD card is not inserted, VDD_SD is disabled, and LS_OE stays off. The proper fix for the HDMI DDC issue would be to maybe have the pinctrl framework manage the pin specific power. Apparently this fixes also a third issue (copy paste from Kishon's patch): ldo1_reg in addition to being connected to the io lines is also connected to the card detect line. On card removal, omap_hsmmc driver does a regulator_disable causing card detect line to be pulled down. This raises a card insertion interrupt and once the MMC core detects there is no card inserted, it does a regulator disable which again raises a card insertion interrupt. This happens in a loop causing infinite MMC interrupts. Fixes: 5a0f93c ("ARM: dts: Add am57xx-beagle-x15") Cc: Kishon Vijay Abraham I <[email protected]> Signed-off-by: Tomi Valkeinen <[email protected]> Reported-by: Louis McCarthy <[email protected]> Acked-by: Nishanth Menon <[email protected]> Signed-off-by: Tony Lindgren <[email protected]>
1 parent 25cb62b commit 7e381ec

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

arch/arm/boot/dts/am57xx-beagle-x15.dts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -402,11 +402,12 @@
402402
/* SMPS9 unused */
403403

404404
ldo1_reg: ldo1 {
405-
/* VDD_SD */
405+
/* VDD_SD / VDDSHV8 */
406406
regulator-name = "ldo1";
407407
regulator-min-microvolt = <1800000>;
408408
regulator-max-microvolt = <3300000>;
409409
regulator-boot-on;
410+
regulator-always-on;
410411
};
411412

412413
ldo2_reg: ldo2 {

0 commit comments

Comments
 (0)