Skip to content

Commit 7ebb9db

Browse files
Tom Rixkuba-moo
authored andcommitted
net: remove unneeded break
A break is not needed if it is preceded by a return or goto Signed-off-by: Tom Rix <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent df6afe2 commit 7ebb9db

File tree

4 files changed

+0
-7
lines changed

4 files changed

+0
-7
lines changed

drivers/net/ethernet/aquantia/atlantic/aq_nic.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1163,7 +1163,6 @@ int aq_nic_set_link_ksettings(struct aq_nic_s *self,
11631163
default:
11641164
err = -1;
11651165
goto err_exit;
1166-
break;
11671166
}
11681167
if (!(self->aq_nic_cfg.aq_hw_caps->link_speed_msk & rate)) {
11691168
err = -1;

drivers/net/ethernet/cisco/enic/enic_ethtool.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -434,7 +434,6 @@ static int enic_grxclsrule(struct enic *enic, struct ethtool_rxnfc *cmd)
434434
break;
435435
default:
436436
return -EINVAL;
437-
break;
438437
}
439438

440439
fsp->h_u.tcp_ip4_spec.ip4src = flow_get_u32_src(&n->keys);

drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -350,7 +350,6 @@ static s32 ixgbe_calc_eeprom_checksum_X540(struct ixgbe_hw *hw)
350350
if (ixgbe_read_eerd_generic(hw, pointer, &length)) {
351351
hw_dbg(hw, "EEPROM read failed\n");
352352
return IXGBE_ERR_EEPROM;
353-
break;
354353
}
355354

356355
/* Skip pointer section if length is invalid. */

drivers/net/wan/lmc/lmc_proto.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -89,17 +89,13 @@ __be16 lmc_proto_type(lmc_softc_t *sc, struct sk_buff *skb) /*FOLD00*/
8989
switch(sc->if_type){
9090
case LMC_PPP:
9191
return hdlc_type_trans(skb, sc->lmc_device);
92-
break;
9392
case LMC_NET:
9493
return htons(ETH_P_802_2);
95-
break;
9694
case LMC_RAW: /* Packet type for skbuff kind of useless */
9795
return htons(ETH_P_802_2);
98-
break;
9996
default:
10097
printk(KERN_WARNING "%s: No protocol set for this interface, assuming 802.2 (which is wrong!!)\n", sc->name);
10198
return htons(ETH_P_802_2);
102-
break;
10399
}
104100
}
105101

0 commit comments

Comments
 (0)