Skip to content

Commit 7ec373c

Browse files
author
Mark Fasheh
committed
ocfs2: document access rules for blocked_lock_list
ocfs2_super->blocked_lock_list and ocfs2_super->blocked_lock_count have some usage restrictions which aren't immediately obvious to anyone reading the code. It's a good idea to document this so that we avoid making costly mistakes in the future. Signed-off-by: Mark Fasheh <[email protected]>
1 parent 116ba5d commit 7ec373c

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

fs/ocfs2/ocfs2.h

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -262,6 +262,12 @@ struct ocfs2_super
262262
unsigned long dc_wake_sequence;
263263
unsigned long dc_work_sequence;
264264

265+
/*
266+
* Any thread can add locks to the list, but the downconvert
267+
* thread is the only one allowed to remove locks. Any change
268+
* to this rule requires updating
269+
* ocfs2_downconvert_thread_do_work().
270+
*/
265271
struct list_head blocked_lock_list;
266272
unsigned long blocked_lock_count;
267273

0 commit comments

Comments
 (0)