Skip to content

Commit 7ee4807

Browse files
windhlstorulf
authored andcommitted
mmc: cavium-thunderx: Add of_node_put() when breaking out of loop
In thunder_mmc_probe(), we should call of_node_put() when breaking out of for_each_child_of_node() which has increased and decreased the refcount during each iteration. Fixes: 166bac3 ("mmc: cavium: Add MMC PCI driver for ThunderX SOCs") Signed-off-by: Liang He <[email protected]> Acked-by: Robert Richter <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Ulf Hansson <[email protected]>
1 parent 19bbb49 commit 7ee4807

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

drivers/mmc/host/cavium-thunderx.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,8 +142,10 @@ static int thunder_mmc_probe(struct pci_dev *pdev,
142142
continue;
143143

144144
ret = cvm_mmc_of_slot_probe(&host->slot_pdev[i]->dev, host);
145-
if (ret)
145+
if (ret) {
146+
of_node_put(child_node);
146147
goto error;
148+
}
147149
}
148150
i++;
149151
}

0 commit comments

Comments
 (0)