Skip to content

Commit 81bd157

Browse files
hsinyi527linusw
authored andcommitted
pinctrl: mediatek: Fix fallback call path
Some SoCs, eg. mt8183, are using a pinconfig operation bias_set_combo. The fallback path in mtk_pinconf_adv_pull_set() should also try this operation. Fixes: cafe19d ("pinctrl: mediatek: Backward compatible to previous Mediatek's bias-pull usage") Signed-off-by: Hsin-Yi Wang <[email protected]> Acked-by: Sean Wang <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Linus Walleij <[email protected]>
1 parent 2f9d9a8 commit 81bd157

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -920,6 +920,10 @@ int mtk_pinconf_adv_pull_set(struct mtk_pinctrl *hw,
920920
err = hw->soc->bias_set(hw, desc, pullup);
921921
if (err)
922922
return err;
923+
} else if (hw->soc->bias_set_combo) {
924+
err = hw->soc->bias_set_combo(hw, desc, pullup, arg);
925+
if (err)
926+
return err;
923927
} else {
924928
return -ENOTSUPP;
925929
}

0 commit comments

Comments
 (0)