Skip to content

Commit 824deff

Browse files
Rostislav PehlivanovJiri Kosina
authored andcommitted
HID: sony: Fix DS4 controller reporting rate issues
This commit removes the cap on the DualShock 4 controller reporting rate when connected using Bluetooth. The previous value of '0xB0' capped the rate to only 20.83 Hz which many userspace utilities mistook as a sign of a bad signal. Since a 'B' and an '8' can look similar it's possible that someone mistook the one for another. The new value of '0x80' enables the full 1000 Hz peak reporting rate that the controller is capable of. Frank adds: "Back when the original code was written the purpose of that value was unknown and 0xB0 seemed to work so that's what ended up being used. Now that we know what it actually does and that 0x80 is a better choice I support this patch." [[email protected]: update changelog] Signed-off-by: Rostislav Pehlivanov <[email protected]> Acked-by: Frank Praznik <[email protected]> Signed-off-by: Jiri Kosina <[email protected]>
1 parent 8f5f0bc commit 824deff

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/hid/hid-sony.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1854,7 +1854,7 @@ static void dualshock4_state_worker(struct work_struct *work)
18541854
} else {
18551855
memset(buf, 0, DS4_REPORT_0x11_SIZE);
18561856
buf[0] = 0x11;
1857-
buf[1] = 0xB0;
1857+
buf[1] = 0x80;
18581858
buf[3] = 0x0F;
18591859
offset = 6;
18601860
}

0 commit comments

Comments
 (0)