Skip to content

Commit 82eabd9

Browse files
Alexander Duyckdavem330
authored andcommitted
net: merge cases where sock_efree and sock_edemux are the same function
Since sock_efree and sock_demux are essentially the same code for non-TCP sockets and the case where CONFIG_INET is not defined we can combine the code or replace the call to sock_edemux in several spots. As a result we can avoid a bit of unnecessary code or code duplication. Signed-off-by: Alexander Duyck <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 62bccb8 commit 82eabd9

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

include/net/sock.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1575,7 +1575,11 @@ void sock_wfree(struct sk_buff *skb);
15751575
void skb_orphan_partial(struct sk_buff *skb);
15761576
void sock_rfree(struct sk_buff *skb);
15771577
void sock_efree(struct sk_buff *skb);
1578+
#ifdef CONFIG_INET
15781579
void sock_edemux(struct sk_buff *skb);
1580+
#else
1581+
#define sock_edemux(skb) sock_efree(skb)
1582+
#endif
15791583

15801584
int sock_setsockopt(struct socket *sock, int level, int op,
15811585
char __user *optval, unsigned int optlen);

net/core/sock.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1643,18 +1643,18 @@ void sock_efree(struct sk_buff *skb)
16431643
}
16441644
EXPORT_SYMBOL(sock_efree);
16451645

1646+
#ifdef CONFIG_INET
16461647
void sock_edemux(struct sk_buff *skb)
16471648
{
16481649
struct sock *sk = skb->sk;
16491650

1650-
#ifdef CONFIG_INET
16511651
if (sk->sk_state == TCP_TIME_WAIT)
16521652
inet_twsk_put(inet_twsk(sk));
16531653
else
1654-
#endif
16551654
sock_put(sk);
16561655
}
16571656
EXPORT_SYMBOL(sock_edemux);
1657+
#endif
16581658

16591659
kuid_t sock_i_uid(struct sock *sk)
16601660
{

net/ipv4/udp.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1972,7 +1972,7 @@ void udp_v4_early_demux(struct sk_buff *skb)
19721972
return;
19731973

19741974
skb->sk = sk;
1975-
skb->destructor = sock_edemux;
1975+
skb->destructor = sock_efree;
19761976
dst = sk->sk_rx_dst;
19771977

19781978
if (dst)

0 commit comments

Comments
 (0)