Skip to content

Commit 8543ae1

Browse files
mugunthanvnmtorvalds
authored andcommitted
checkpatch: add Suggested-by as a standard signature
As people started using Suggested-by as standard signature, adding "Suggested-by" to the standard signature so that checkpatch won't generate warning when Suggested-by is used in patch signature Signed-off-by: Mugunthan V N <[email protected]> Cc: Andy Whitcroft <[email protected]> Cc: Joe Perches <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent 74c8f43 commit 8543ae1

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

Documentation/SubmittingPatches

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -420,7 +420,7 @@ person it names. This tag documents that potentially interested parties
420420
have been included in the discussion
421421

422422

423-
14) Using Reported-by:, Tested-by: and Reviewed-by:
423+
14) Using Reported-by:, Tested-by:, Reviewed-by: and Suggested-by:
424424

425425
If this patch fixes a problem reported by somebody else, consider adding a
426426
Reported-by: tag to credit the reporter for their contribution. Please
@@ -468,6 +468,13 @@ done on the patch. Reviewed-by: tags, when supplied by reviewers known to
468468
understand the subject area and to perform thorough reviews, will normally
469469
increase the likelihood of your patch getting into the kernel.
470470

471+
A Suggested-by: tag indicates that the patch idea is suggested by the person
472+
named and ensures credit to the person for the idea. Please note that this
473+
tag should not be added without the reporter's permission, especially if the
474+
idea was not posted in a public forum. That said, if we diligently credit our
475+
idea reporters, they will, hopefully, be inspired to help us again in the
476+
future.
477+
471478

472479
15) The canonical patch format
473480

scripts/checkpatch.pl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -281,6 +281,7 @@ sub help {
281281
Tested-by:|
282282
Reviewed-by:|
283283
Reported-by:|
284+
Suggested-by:|
284285
To:|
285286
Cc:
286287
)};

0 commit comments

Comments
 (0)