Skip to content

Commit 8634449

Browse files
johnpgarrymartinkpetersen
authored andcommitted
scsi: libsas: Delete sas_ata_task.retry_count
Since libsas was introduced in commit 2908d77 ("[SCSI] aic94xx: new driver"), sas_ata_task.retry_count is never set, so delete it and the reference in asd_build_ata_ascb(). Signed-off-by: John Garry <[email protected]> Link: https://lore.kernel.org/r/[email protected] Reviewed-by: Damien Le Moal <[email protected]> Reviewed-by: Jason Yan <[email protected]> Signed-off-by: Martin K. Petersen <[email protected]>
1 parent 44862dc commit 8634449

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

drivers/scsi/aic94xx/aic94xx_task.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -388,7 +388,7 @@ static int asd_build_ata_ascb(struct asd_ascb *ascb, struct sas_task *task,
388388
flags |= data_dir_flags[task->data_dir];
389389
scb->ata_task.ata_flags = flags;
390390

391-
scb->ata_task.retry_count = task->ata_task.retry_count;
391+
scb->ata_task.retry_count = 0;
392392

393393
scb->ata_task.flags = 0;
394394
}

include/scsi/libsas.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -525,8 +525,6 @@ struct sas_ata_task {
525525
struct host_to_dev_fis fis;
526526
u8 atapi_packet[16]; /* 0 if not ATAPI task */
527527

528-
u8 retry_count; /* hardware retry, should be > 0 */
529-
530528
u8 dma_xfer:1; /* PIO:0 or DMA:1 */
531529
u8 use_ncq:1;
532530

0 commit comments

Comments
 (0)