Skip to content

Commit 86b1e8d

Browse files
Shaohua LiIngo Molnar
authored andcommitted
x86: Make relocatable kernel work with new binutils
The CONFIG_RELOCATABLE=y option is broken with new binutils, which will make boot panic. According to Lu Hongjiu, the affected binutils are from 2.20.51.0.12 to 2.21.51.0.3, which are release since Oct 22 this year. At least ubuntu 10.10 is using such binutils. See: http://sourceware.org/bugzilla/show_bug.cgi?id=12327 The reason of the boot panic is that we have 'jiffies = jiffies_64;' in vmlinux.lds.S. The jiffies isn't in any section. In kernel build, there is warning saying jiffies is an absolute address and can't be relocatable. At runtime, jiffies will have virtual address 0. Signed-off-by: Shaohua Li<[email protected]> Cc: Lu Hongjiu<[email protected]> Cc: Huang Ying <[email protected]> Cc: Sam Ravnborg <[email protected]> LKML-Reference: <1295312269.1949.725.camel@sli10-conroe> Signed-off-by: Ingo Molnar <[email protected]>
1 parent 76d1f7b commit 86b1e8d

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

arch/x86/kernel/vmlinux.lds.S

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,9 @@ OUTPUT_FORMAT(CONFIG_OUTPUT_FORMAT, CONFIG_OUTPUT_FORMAT, CONFIG_OUTPUT_FORMAT)
3434
#ifdef CONFIG_X86_32
3535
OUTPUT_ARCH(i386)
3636
ENTRY(phys_startup_32)
37-
jiffies = jiffies_64;
3837
#else
3938
OUTPUT_ARCH(i386:x86-64)
4039
ENTRY(phys_startup_64)
41-
jiffies_64 = jiffies;
4240
#endif
4341

4442
#if defined(CONFIG_X86_64) && defined(CONFIG_DEBUG_RODATA)
@@ -142,6 +140,15 @@ SECTIONS
142140
CACHELINE_ALIGNED_DATA(L1_CACHE_BYTES)
143141

144142
DATA_DATA
143+
/*
144+
* Workaround a binutils (2.20.51.0.12 to 2.21.51.0.3) bug.
145+
* This makes jiffies relocatable in such binutils
146+
*/
147+
#ifdef CONFIG_X86_32
148+
jiffies = jiffies_64;
149+
#else
150+
jiffies_64 = jiffies;
151+
#endif
145152
CONSTRUCTORS
146153

147154
/* rarely changed data like cpu maps */

0 commit comments

Comments
 (0)