Skip to content

Commit 86bcd3a

Browse files
lynxeye-devdtor
authored andcommitted
Input: synaptics-rmi4 - re-enable IRQs in f34v7_do_reflash
F34 is a bit special as it reinitializes the device and related driver structs during the firmware update. This clears the fn_irq_mask which will then prevent F34 from receiving further interrupts, leading to timeouts during the firmware update. Make sure to reinitialize the IRQ enables at the appropriate times. The issue is in F34 code, but the commit in the fixes tag exposed the issue, as before this commit things would work by accident. Fixes: 363c538 (Input: synaptics-rmi4 - avoid processing unknown IRQs) Signed-off-by: Lucas Stach <[email protected]> Link: https://lore.kernel.org/r/[email protected] Cc: [email protected] Signed-off-by: Dmitry Torokhov <[email protected]>
1 parent df5b5e5 commit 86bcd3a

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

drivers/input/rmi4/rmi_f34v7.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1189,6 +1189,9 @@ int rmi_f34v7_do_reflash(struct f34_data *f34, const struct firmware *fw)
11891189
{
11901190
int ret;
11911191

1192+
f34->fn->rmi_dev->driver->set_irq_bits(f34->fn->rmi_dev,
1193+
f34->fn->irq_mask);
1194+
11921195
rmi_f34v7_read_queries_bl_version(f34);
11931196

11941197
f34->v7.image = fw->data;

0 commit comments

Comments
 (0)