Skip to content

Commit 86c5dd6

Browse files
dtorlinusw
authored andcommitted
pinctrl: cherryview: limit Strago DMI workarounds to version 1.0
As Google/Intel will fix the BIOS/Coreboot issues with hardcoding virtual interrupt numbers for keyboard/touchpad/touchscreen controllers in ACPI tables, they will also update BOARD version number from 1.0 to 1.1. Let's limit the DMI quirks that try to preserve virtual IRQ numbers on Strago boards to those that still carry older BIOSes. Note that ideally not BOARD but BIOS version should have been updated. However the BIOS version used by Chrome devices has format of Google_BUILD.BRANCH.PATCH which is not well suited for DMI matching as we do not have "less than" match mode for DMI data. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=197953 Signed-off-by: Dmitry Torokhov <[email protected]> Acked-by: Mika Westerberg <[email protected]> Reviewed-by: Guenter Roeck <[email protected]> Acked-by: Andy Shevchenko <[email protected]> Signed-off-by: Linus Walleij <[email protected]>
1 parent 2181636 commit 86c5dd6

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

drivers/pinctrl/intel/pinctrl-cherryview.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1527,27 +1527,31 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
15271527
.matches = {
15281528
DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
15291529
DMI_MATCH(DMI_PRODUCT_FAMILY, "Intel_Strago"),
1530+
DMI_MATCH(DMI_BOARD_VERSION, "1.0"),
15301531
},
15311532
},
15321533
{
15331534
.ident = "HP Chromebook 11 G5 (Setzer)",
15341535
.matches = {
15351536
DMI_MATCH(DMI_SYS_VENDOR, "HP"),
15361537
DMI_MATCH(DMI_PRODUCT_NAME, "Setzer"),
1538+
DMI_MATCH(DMI_BOARD_VERSION, "1.0"),
15371539
},
15381540
},
15391541
{
15401542
.ident = "Acer Chromebook R11 (Cyan)",
15411543
.matches = {
15421544
DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
15431545
DMI_MATCH(DMI_PRODUCT_NAME, "Cyan"),
1546+
DMI_MATCH(DMI_BOARD_VERSION, "1.0"),
15441547
},
15451548
},
15461549
{
15471550
.ident = "Samsung Chromebook 3 (Celes)",
15481551
.matches = {
15491552
DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
15501553
DMI_MATCH(DMI_PRODUCT_NAME, "Celes"),
1554+
DMI_MATCH(DMI_BOARD_VERSION, "1.0"),
15511555
},
15521556
},
15531557
{}

0 commit comments

Comments
 (0)