Skip to content

Commit 878c33a

Browse files
quyteldagregkh
authored andcommitted
Staging: ion: fix code style warning from NULL comparisons
This patch replaces several instances where a pointer is compared to NULL (i.e., `ptr == NULL`) with `!ptr`, which is preferred. Signed-off-by: Quytelda Kahja <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent bd18c0c commit 878c33a

File tree

1 file changed

+3
-3
lines changed
  • drivers/staging/android/ion

1 file changed

+3
-3
lines changed

drivers/staging/android/ion/ion.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ static struct ion_buffer *ion_buffer_create(struct ion_heap *heap,
103103
goto err2;
104104
}
105105

106-
if (buffer->sg_table == NULL) {
106+
if (!buffer->sg_table) {
107107
WARN_ONCE(1, "This heap needs to set the sgtable");
108108
ret = -EINVAL;
109109
goto err1;
@@ -161,7 +161,7 @@ static void *ion_buffer_kmap_get(struct ion_buffer *buffer)
161161
return buffer->vaddr;
162162
}
163163
vaddr = buffer->heap->ops->map_kernel(buffer->heap, buffer);
164-
if (WARN_ONCE(vaddr == NULL,
164+
if (WARN_ONCE(!vaddr,
165165
"heap->ops->map_kernel should return ERR_PTR on error"))
166166
return ERR_PTR(-EINVAL);
167167
if (IS_ERR(vaddr))
@@ -425,7 +425,7 @@ int ion_alloc(size_t len, unsigned int heap_id_mask, unsigned int flags)
425425
}
426426
up_read(&dev->lock);
427427

428-
if (buffer == NULL)
428+
if (!buffer)
429429
return -ENODEV;
430430

431431
if (IS_ERR(buffer))

0 commit comments

Comments
 (0)