Skip to content

Commit 879be4f

Browse files
JoePerchestorvalds
authored andcommitted
checkpatch: reduce git commit description style false positives
Some lines in a commit log appear to be commit SHA1 ids like: ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0123456789ab ("commit description")' Link: http://lkml.kernel.org/r/40e03fd7aaf1f55c75d787128d6d17c5a71226c2.1464358556.git.vdavydov@virtuozzo.com Reduce the false positives. Link: http://lkml.kernel.org/r/eda977eaa8328fef42bb3c87935d97e10ea8ff67.1464384023.git.joe@perches.com Signed-off-by: Joe Perches <[email protected]> Reported-by: Andrew Morton <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent 43afc19 commit 879be4f

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

scripts/checkpatch.pl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2454,6 +2454,7 @@ sub process {
24542454

24552455
# Check for git id commit length and improperly formed commit descriptions
24562456
if ($in_commit_log && !$commit_log_possible_stack_dump &&
2457+
$line !~ /^\s*(?:Link|Patchwork|http|BugLink):/i &&
24572458
($line =~ /\bcommit\s+[0-9a-f]{5,}\b/i ||
24582459
($line =~ /\b[0-9a-f]{12,40}\b/i &&
24592460
$line !~ /[\<\[][0-9a-f]{12,40}[\>\]]/i &&

0 commit comments

Comments
 (0)