HID: amd_sfh: Move global functions to static

basuamd · Jiri Kosina · commit 87cb795291bb · 2022-07-21T13:43:59.000+02:00
Move global functions declared from header files and make them as static
functions wherever applicable.

Signed-off-by: Basavaraj Natikar &lt;Basavaraj.Natikar@amd.com&gt;
Signed-off-by: Jiri Kosina &lt;jkosina@suse.cz&gt;
diff --git a/drivers/hid/amd-sfh-hid/amd_sfh_client.c b/drivers/hid/amd-sfh-hid/amd_sfh_client.c
@@ -129,15 +129,15 @@ static void amd_sfh_work_buffer(struct work_struct *work)
 	schedule_delayed_work(&cli_data->work_buffer, msecs_to_jiffies(AMD_SFH_IDLE_LOOP));
 }
 
-u32 amd_sfh_wait_for_response(struct amd_mp2_dev *mp2, u8 sid, u32 sensor_sts)
+static u32 amd_sfh_wait_for_response(struct amd_mp2_dev *mp2, u8 sid, u32 sensor_sts)
 {
 	if (mp2->mp2_ops->response)
 		sensor_sts = mp2->mp2_ops->response(mp2, sid, sensor_sts);
 
 	return sensor_sts;
 }
 
-const char *get_sensor_name(int idx)
+static const char *get_sensor_name(int idx)
 {
 	switch (idx) {
 	case accel_idx:
diff --git a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
@@ -136,7 +136,7 @@ static int amd_sfh_dis_sts_v2(struct amd_mp2_dev *privdata)
 		      SENSOR_DISCOVERY_STATUS_MASK) >> SENSOR_DISCOVERY_STATUS_SHIFT;
 }
 
-void amd_start_sensor(struct amd_mp2_dev *privdata, struct amd_mp2_sensor_info info)
+static void amd_start_sensor(struct amd_mp2_dev *privdata, struct amd_mp2_sensor_info info)
 {
 	union sfh_cmd_param cmd_param;
 	union sfh_cmd_base cmd_base;
@@ -157,7 +157,7 @@ void amd_start_sensor(struct amd_mp2_dev *privdata, struct amd_mp2_sensor_info i
 	writel(cmd_base.ul, privdata->mmio + AMD_C2P_MSG0);
 }
 
-void amd_stop_sensor(struct amd_mp2_dev *privdata, u16 sensor_idx)
+static void amd_stop_sensor(struct amd_mp2_dev *privdata, u16 sensor_idx)
 {
 	union sfh_cmd_base cmd_base;
 
@@ -171,7 +171,7 @@ void amd_stop_sensor(struct amd_mp2_dev *privdata, u16 sensor_idx)
 	writel(cmd_base.ul, privdata->mmio + AMD_C2P_MSG0);
 }
 
-void amd_stop_all_sensors(struct amd_mp2_dev *privdata)
+static void amd_stop_all_sensors(struct amd_mp2_dev *privdata)
 {
 	union sfh_cmd_base cmd_base;
 
diff --git a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.h b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.h
@@ -98,16 +98,9 @@ struct hpd_status {
 	};
 };
 
-void amd_start_sensor(struct amd_mp2_dev *privdata, struct amd_mp2_sensor_info info);
-void amd_stop_sensor(struct amd_mp2_dev *privdata, u16 sensor_idx);
-void amd_stop_all_sensors(struct amd_mp2_dev *privdata);
 int amd_mp2_get_sensor_num(struct amd_mp2_dev *privdata, u8 *sensor_id);
 int amd_sfh_hid_client_init(struct amd_mp2_dev *privdata);
 int amd_sfh_hid_client_deinit(struct amd_mp2_dev *privdata);
-u32 amd_sfh_wait_for_response(struct amd_mp2_dev *mp2, u8 sid, u32 sensor_sts);
-void amd_mp2_suspend(struct amd_mp2_dev *mp2);
-void amd_mp2_resume(struct amd_mp2_dev *mp2);
-const char *get_sensor_name(int idx);
 void amd_sfh_set_desc_ops(struct amd_mp2_ops *mp2_ops);
 
 #endif

Original file line number	Diff line number	Diff line change
`@@ -129,15 +129,15 @@ static void amd_sfh_work_buffer(struct work_struct *work)`
`129`	`129`	`schedule_delayed_work(&cli_data->work_buffer, msecs_to_jiffies(AMD_SFH_IDLE_LOOP));`
`130`	`130`	`}`
`131`	`131`
`132`		`-u32 amd_sfh_wait_for_response(struct amd_mp2_dev *mp2, u8 sid, u32 sensor_sts)`
	`132`	`+static u32 amd_sfh_wait_for_response(struct amd_mp2_dev *mp2, u8 sid, u32 sensor_sts)`
`133`	`133`	`{`
`134`	`134`	`if (mp2->mp2_ops->response)`
`135`	`135`	`sensor_sts = mp2->mp2_ops->response(mp2, sid, sensor_sts);`
`136`	`136`
`137`	`137`	`return sensor_sts;`
`138`	`138`	`}`
`139`	`139`
`140`		`-const char *get_sensor_name(int idx)`
	`140`	`+static const char *get_sensor_name(int idx)`
`141`	`141`	`{`
`142`	`142`	`switch (idx) {`
`143`	`143`	`case accel_idx:`
Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,7 @@ static int amd_sfh_dis_sts_v2(struct amd_mp2_dev *privdata)`
`136`	`136`	`SENSOR_DISCOVERY_STATUS_MASK) >> SENSOR_DISCOVERY_STATUS_SHIFT;`
`137`	`137`	`}`
`138`	`138`
`139`		`-void amd_start_sensor(struct amd_mp2_dev *privdata, struct amd_mp2_sensor_info info)`
	`139`	`+static void amd_start_sensor(struct amd_mp2_dev *privdata, struct amd_mp2_sensor_info info)`
`140`	`140`	`{`
`141`	`141`	`union sfh_cmd_param cmd_param;`
`142`	`142`	`union sfh_cmd_base cmd_base;`
`@@ -157,7 +157,7 @@ void amd_start_sensor(struct amd_mp2_dev *privdata, struct amd_mp2_sensor_info i`
`157`	`157`	`writel(cmd_base.ul, privdata->mmio + AMD_C2P_MSG0);`
`158`	`158`	`}`
`159`	`159`
`160`		`-void amd_stop_sensor(struct amd_mp2_dev *privdata, u16 sensor_idx)`
	`160`	`+static void amd_stop_sensor(struct amd_mp2_dev *privdata, u16 sensor_idx)`
`161`	`161`	`{`
`162`	`162`	`union sfh_cmd_base cmd_base;`
`163`	`163`
`@@ -171,7 +171,7 @@ void amd_stop_sensor(struct amd_mp2_dev *privdata, u16 sensor_idx)`
`171`	`171`	`writel(cmd_base.ul, privdata->mmio + AMD_C2P_MSG0);`
`172`	`172`	`}`
`173`	`173`
`174`		`-void amd_stop_all_sensors(struct amd_mp2_dev *privdata)`
	`174`	`+static void amd_stop_all_sensors(struct amd_mp2_dev *privdata)`
`175`	`175`	`{`
`176`	`176`	`union sfh_cmd_base cmd_base;`
`177`	`177`