Skip to content

Commit 88134fa

Browse files
Archit Tanejatomba
authored andcommitted
OMAP2PLUS: DSS2: Make members of dss_clk_source generic
The enum members of 'dss_clk_source' have clock source names specific to OMAP2/3. Change the names to more generic terms such that they now describe where the clocks come from and what they are used for. Also, change the enum member names to have "DSS_CLK_SRC" instead of "DSS_SRC" for more clarity. Signed-off-by: Archit Taneja <[email protected]> Signed-off-by: Tomi Valkeinen <[email protected]>
1 parent 819d807 commit 88134fa

File tree

5 files changed

+27
-27
lines changed

5 files changed

+27
-27
lines changed

drivers/video/omap2/dss/dispc.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2334,7 +2334,7 @@ unsigned long dispc_fclk_rate(void)
23342334
{
23352335
unsigned long r = 0;
23362336

2337-
if (dss_get_dispc_clk_source() == DSS_SRC_DSS1_ALWON_FCLK)
2337+
if (dss_get_dispc_clk_source() == DSS_CLK_SRC_FCK)
23382338
r = dss_clk_get_rate(DSS_CLK_FCK);
23392339
else
23402340
#ifdef CONFIG_OMAP2_DSS_DSI
@@ -2385,7 +2385,7 @@ void dispc_dump_clocks(struct seq_file *s)
23852385
seq_printf(s, "- DISPC -\n");
23862386

23872387
seq_printf(s, "dispc fclk source = %s\n",
2388-
dss_get_dispc_clk_source() == DSS_SRC_DSS1_ALWON_FCLK ?
2388+
dss_get_dispc_clk_source() == DSS_CLK_SRC_FCK ?
23892389
"dss1_alwon_fclk" : "dsi1_pll_fclk");
23902390

23912391
seq_printf(s, "fck\t\t%-16lu\n", dispc_fclk_rate());

drivers/video/omap2/dss/dpi.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ static int dpi_set_dsi_clk(struct omap_dss_device *dssdev, bool is_tft,
5757
if (r)
5858
return r;
5959

60-
dss_select_dispc_clk_source(DSS_SRC_DSI1_PLL_FCLK);
60+
dss_select_dispc_clk_source(DSS_CLK_SRC_DSI_PLL_HSDIV_DISPC);
6161

6262
r = dispc_set_clock_div(dssdev->manager->id, &dispc_cinfo);
6363
if (r)
@@ -217,7 +217,7 @@ void omapdss_dpi_display_disable(struct omap_dss_device *dssdev)
217217
dssdev->manager->disable(dssdev->manager);
218218

219219
#ifdef CONFIG_OMAP2_DSS_USE_DSI_PLL
220-
dss_select_dispc_clk_source(DSS_SRC_DSS1_ALWON_FCLK);
220+
dss_select_dispc_clk_source(DSS_CLK_SRC_FCK);
221221
dsi_pll_uninit();
222222
dss_clk_disable(DSS_CLK_SYSCK);
223223
#endif

drivers/video/omap2/dss/dsi.c

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -731,7 +731,7 @@ static unsigned long dsi_fclk_rate(void)
731731
{
732732
unsigned long r;
733733

734-
if (dss_get_dsi_clk_source() == DSS_SRC_DSS1_ALWON_FCLK) {
734+
if (dss_get_dsi_clk_source() == DSS_CLK_SRC_FCK) {
735735
/* DSI FCLK source is DSS1_ALWON_FCK, which is dss1_fck */
736736
r = dss_clk_get_rate(DSS_CLK_FCK);
737737
} else {
@@ -1188,19 +1188,19 @@ void dsi_dump_clocks(struct seq_file *s)
11881188
seq_printf(s, "dsi1_pll_fck\t%-16luregm3 %u\t(%s)\n",
11891189
cinfo->dsi1_pll_fclk,
11901190
cinfo->regm3,
1191-
dss_get_dispc_clk_source() == DSS_SRC_DSS1_ALWON_FCLK ?
1191+
dss_get_dispc_clk_source() == DSS_CLK_SRC_FCK ?
11921192
"off" : "on");
11931193

11941194
seq_printf(s, "dsi2_pll_fck\t%-16luregm4 %u\t(%s)\n",
11951195
cinfo->dsi2_pll_fclk,
11961196
cinfo->regm4,
1197-
dss_get_dsi_clk_source() == DSS_SRC_DSS1_ALWON_FCLK ?
1197+
dss_get_dsi_clk_source() == DSS_CLK_SRC_FCK ?
11981198
"off" : "on");
11991199

12001200
seq_printf(s, "- DSI -\n");
12011201

12021202
seq_printf(s, "dsi fclk source = %s\n",
1203-
dss_get_dsi_clk_source() == DSS_SRC_DSS1_ALWON_FCLK ?
1203+
dss_get_dsi_clk_source() == DSS_CLK_SRC_FCK ?
12041204
"dss1_alwon_fclk" : "dsi2_pll_fclk");
12051205

12061206
seq_printf(s, "DSI_FCLK\t%lu\n", dsi_fclk_rate());
@@ -3038,8 +3038,8 @@ static int dsi_display_init_dsi(struct omap_dss_device *dssdev)
30383038
if (r)
30393039
goto err1;
30403040

3041-
dss_select_dispc_clk_source(DSS_SRC_DSI1_PLL_FCLK);
3042-
dss_select_dsi_clk_source(DSS_SRC_DSI2_PLL_FCLK);
3041+
dss_select_dispc_clk_source(DSS_CLK_SRC_DSI_PLL_HSDIV_DISPC);
3042+
dss_select_dsi_clk_source(DSS_CLK_SRC_DSI_PLL_HSDIV_DSI);
30433043

30443044
DSSDBG("PLL OK\n");
30453045

@@ -3075,8 +3075,8 @@ static int dsi_display_init_dsi(struct omap_dss_device *dssdev)
30753075
err3:
30763076
dsi_complexio_uninit();
30773077
err2:
3078-
dss_select_dispc_clk_source(DSS_SRC_DSS1_ALWON_FCLK);
3079-
dss_select_dsi_clk_source(DSS_SRC_DSS1_ALWON_FCLK);
3078+
dss_select_dispc_clk_source(DSS_CLK_SRC_FCK);
3079+
dss_select_dsi_clk_source(DSS_CLK_SRC_FCK);
30803080
err1:
30813081
dsi_pll_uninit();
30823082
err0:
@@ -3092,8 +3092,8 @@ static void dsi_display_uninit_dsi(struct omap_dss_device *dssdev)
30923092
dsi_vc_enable(2, 0);
30933093
dsi_vc_enable(3, 0);
30943094

3095-
dss_select_dispc_clk_source(DSS_SRC_DSS1_ALWON_FCLK);
3096-
dss_select_dsi_clk_source(DSS_SRC_DSS1_ALWON_FCLK);
3095+
dss_select_dispc_clk_source(DSS_CLK_SRC_FCK);
3096+
dss_select_dsi_clk_source(DSS_CLK_SRC_FCK);
30973097
dsi_complexio_uninit();
30983098
dsi_pll_uninit();
30993099
}

drivers/video/omap2/dss/dss.c

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -278,12 +278,12 @@ void dss_select_dispc_clk_source(enum dss_clk_source clk_src)
278278
{
279279
int b;
280280

281-
BUG_ON(clk_src != DSS_SRC_DSI1_PLL_FCLK &&
282-
clk_src != DSS_SRC_DSS1_ALWON_FCLK);
281+
BUG_ON(clk_src != DSS_CLK_SRC_DSI_PLL_HSDIV_DISPC &&
282+
clk_src != DSS_CLK_SRC_FCK);
283283

284-
b = clk_src == DSS_SRC_DSS1_ALWON_FCLK ? 0 : 1;
284+
b = clk_src == DSS_CLK_SRC_FCK ? 0 : 1;
285285

286-
if (clk_src == DSS_SRC_DSI1_PLL_FCLK)
286+
if (clk_src == DSS_CLK_SRC_DSI_PLL_HSDIV_DISPC)
287287
dsi_wait_dsi1_pll_active();
288288

289289
REG_FLD_MOD(DSS_CONTROL, b, 0, 0); /* DISPC_CLK_SWITCH */
@@ -295,12 +295,12 @@ void dss_select_dsi_clk_source(enum dss_clk_source clk_src)
295295
{
296296
int b;
297297

298-
BUG_ON(clk_src != DSS_SRC_DSI2_PLL_FCLK &&
299-
clk_src != DSS_SRC_DSS1_ALWON_FCLK);
298+
BUG_ON(clk_src != DSS_CLK_SRC_DSI_PLL_HSDIV_DSI &&
299+
clk_src != DSS_CLK_SRC_FCK);
300300

301-
b = clk_src == DSS_SRC_DSS1_ALWON_FCLK ? 0 : 1;
301+
b = clk_src == DSS_CLK_SRC_FCK ? 0 : 1;
302302

303-
if (clk_src == DSS_SRC_DSI2_PLL_FCLK)
303+
if (clk_src == DSS_CLK_SRC_DSI_PLL_HSDIV_DSI)
304304
dsi_wait_dsi2_pll_active();
305305

306306
REG_FLD_MOD(DSS_CONTROL, b, 1, 1); /* DSI_CLK_SWITCH */
@@ -601,8 +601,8 @@ static int dss_init(bool skip_init)
601601
}
602602
}
603603

604-
dss.dsi_clk_source = DSS_SRC_DSS1_ALWON_FCLK;
605-
dss.dispc_clk_source = DSS_SRC_DSS1_ALWON_FCLK;
604+
dss.dsi_clk_source = DSS_CLK_SRC_FCK;
605+
dss.dispc_clk_source = DSS_CLK_SRC_FCK;
606606

607607
dss_save_context();
608608

drivers/video/omap2/dss/dss.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -118,9 +118,9 @@ enum dss_clock {
118118
};
119119

120120
enum dss_clk_source {
121-
DSS_SRC_DSI1_PLL_FCLK,
122-
DSS_SRC_DSI2_PLL_FCLK,
123-
DSS_SRC_DSS1_ALWON_FCLK,
121+
DSS_CLK_SRC_DSI_PLL_HSDIV_DISPC, /* DSI1_PLL_FCLK */
122+
DSS_CLK_SRC_DSI_PLL_HSDIV_DSI, /* DSI2_PLL_FCLK */
123+
DSS_CLK_SRC_FCK, /* DSS1_ALWON_FCLK */
124124
};
125125

126126
struct dss_clock_info {

0 commit comments

Comments
 (0)