USB: gadget: udc: Add missing platform_device_put() on error in bdc_pci_probe()

Wei Yongjun · Felipe Balbi · commit 8874ae5f15f3 · 2018-02-15T15:28:13.000+02:00
Add the missing platform_device_put() before return from bdc_pci_probe() in the platform_device_add_resources() error handling case. Fixes: efed421 ("usb: gadget: Add UDC driver for Broadcom USB3.0 device controller IP BDC") Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
diff --git a/drivers/usb/gadget/udc/bdc/bdc_pci.c b/drivers/usb/gadget/udc/bdc/bdc_pci.c
@@ -77,6 +77,7 @@ static int bdc_pci_probe(struct pci_dev *pci, const struct pci_device_id *id)
 	if (ret) {
 		dev_err(&pci->dev,
 			"couldn't add resources to bdc device\n");
+		platform_device_put(bdc);
 		return ret;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -77,6 +77,7 @@ static int bdc_pci_probe(struct pci_dev pci, const struct pci_device_id id)`
`77`	`77`	`if (ret) {`
`78`	`78`	`dev_err(&pci->dev,`
`79`	`79`	`"couldn't add resources to bdc device\n");`
	`80`	`+ platform_device_put(bdc);`
`80`	`81`	`return ret;`
`81`	`82`	`}`
`82`	`83`