Skip to content

Commit 88e20c7

Browse files
lategoodbyeJason Cooper
authored andcommitted
irqchip/mxs: Enable SKIP_SET_WAKE and MASK_ON_SUSPEND
The ICOLL controller doesn't provide any facility to configure the wakeup sources. That's the reason why this implementation lacks the irq_set_wake implementation. But this prevent us from properly entering power management states like "suspend to idle". So enable the flags IRQCHIP_SKIP_SET_WAKE and IRQCHIP_MASK_ON_SUSPEND to let the irqchip core allows and handles the power management. Signed-off-by: Stefan Wahren <[email protected]> Reviewed-by: Fabio Estevam <[email protected]> Link: https://lkml.kernel.org/r/[email protected] Signed-off-by: Jason Cooper <[email protected]>
1 parent 2f884e6 commit 88e20c7

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

drivers/irqchip/irq-mxs.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,12 +131,16 @@ static struct irq_chip mxs_icoll_chip = {
131131
.irq_ack = icoll_ack_irq,
132132
.irq_mask = icoll_mask_irq,
133133
.irq_unmask = icoll_unmask_irq,
134+
.flags = IRQCHIP_MASK_ON_SUSPEND |
135+
IRQCHIP_SKIP_SET_WAKE,
134136
};
135137

136138
static struct irq_chip asm9260_icoll_chip = {
137139
.irq_ack = icoll_ack_irq,
138140
.irq_mask = asm9260_mask_irq,
139141
.irq_unmask = asm9260_unmask_irq,
142+
.flags = IRQCHIP_MASK_ON_SUSPEND |
143+
IRQCHIP_SKIP_SET_WAKE,
140144
};
141145

142146
asmlinkage void __exception_irq_entry icoll_handle_irq(struct pt_regs *regs)

0 commit comments

Comments
 (0)