Skip to content

Commit 8994a51

Browse files
committed
lockd: Remove unused parameter to nlmsvc_testlock()
The nlm_cookie parameter has been unused since commit 09802fd ("lockd: rip out deferred lock handling from testlock codepath"). Reviewed-by: Jeff Layton <[email protected]> Reviewed-by: NeilBrown <[email protected]> Signed-off-by: Chuck Lever <[email protected]>
1 parent a872c73 commit 8994a51

File tree

4 files changed

+8
-6
lines changed

4 files changed

+8
-6
lines changed

fs/lockd/svc4proc.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,8 @@ __nlm4svc_proc_test(struct svc_rqst *rqstp, struct nlm_res *resp)
108108

109109
test_owner = argp->lock.fl.c.flc_owner;
110110
/* Now check for conflicting locks */
111-
resp->status = nlmsvc_testlock(rqstp, file, host, &argp->lock, &resp->lock, &resp->cookie);
111+
resp->status = nlmsvc_testlock(rqstp, file, host, &argp->lock,
112+
&resp->lock);
112113
if (resp->status == nlm_drop_reply)
113114
rc = rpc_drop_reply;
114115
else

fs/lockd/svclock.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -609,7 +609,7 @@ nlmsvc_lock(struct svc_rqst *rqstp, struct nlm_file *file,
609609
__be32
610610
nlmsvc_testlock(struct svc_rqst *rqstp, struct nlm_file *file,
611611
struct nlm_host *host, struct nlm_lock *lock,
612-
struct nlm_lock *conflock, struct nlm_cookie *cookie)
612+
struct nlm_lock *conflock)
613613
{
614614
int error;
615615
int mode;

fs/lockd/svcproc.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,8 @@ __nlmsvc_proc_test(struct svc_rqst *rqstp, struct nlm_res *resp)
130130
test_owner = argp->lock.fl.c.flc_owner;
131131

132132
/* Now check for conflicting locks */
133-
resp->status = cast_status(nlmsvc_testlock(rqstp, file, host, &argp->lock, &resp->lock, &resp->cookie));
133+
resp->status = cast_status(nlmsvc_testlock(rqstp, file, host,
134+
&argp->lock, &resp->lock));
134135
if (resp->status == nlm_drop_reply)
135136
rc = rpc_drop_reply;
136137
else

include/linux/lockd/lockd.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -278,9 +278,9 @@ __be32 nlmsvc_lock(struct svc_rqst *, struct nlm_file *,
278278
struct nlm_host *, struct nlm_lock *, int,
279279
struct nlm_cookie *, int);
280280
__be32 nlmsvc_unlock(struct net *net, struct nlm_file *, struct nlm_lock *);
281-
__be32 nlmsvc_testlock(struct svc_rqst *, struct nlm_file *,
282-
struct nlm_host *, struct nlm_lock *,
283-
struct nlm_lock *, struct nlm_cookie *);
281+
__be32 nlmsvc_testlock(struct svc_rqst *rqstp, struct nlm_file *file,
282+
struct nlm_host *host, struct nlm_lock *lock,
283+
struct nlm_lock *conflock);
284284
__be32 nlmsvc_cancel_blocked(struct net *net, struct nlm_file *, struct nlm_lock *);
285285
void nlmsvc_retry_blocked(struct svc_rqst *rqstp);
286286
void nlmsvc_traverse_blocks(struct nlm_host *, struct nlm_file *,

0 commit comments

Comments
 (0)