Skip to content

Commit 89bda97

Browse files
sf-hgkdavem330
authored andcommitted
sfc: check RSS is active for filter insert
For some firmware variants - specifically 'capture packed stream' - RSS filters are not valid. We must check if RSS is actually active rather than merely enabled. Fixes: 42356d9 ("sfc: support RSS spreading of ethtool ntuple filters") Signed-off-by: Bert Kenward <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 7ce2367 commit 89bda97

File tree

1 file changed

+2
-2
lines changed
  • drivers/net/ethernet/sfc

1 file changed

+2
-2
lines changed

drivers/net/ethernet/sfc/ef10.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5264,7 +5264,7 @@ static int efx_ef10_filter_insert_addr_list(struct efx_nic *efx,
52645264
ids = vlan->uc;
52655265
}
52665266

5267-
filter_flags = efx_rss_enabled(efx) ? EFX_FILTER_FLAG_RX_RSS : 0;
5267+
filter_flags = efx_rss_active(&efx->rss_context) ? EFX_FILTER_FLAG_RX_RSS : 0;
52685268

52695269
/* Insert/renew filters */
52705270
for (i = 0; i < addr_count; i++) {
@@ -5333,7 +5333,7 @@ static int efx_ef10_filter_insert_def(struct efx_nic *efx,
53335333
int rc;
53345334
u16 *id;
53355335

5336-
filter_flags = efx_rss_enabled(efx) ? EFX_FILTER_FLAG_RX_RSS : 0;
5336+
filter_flags = efx_rss_active(&efx->rss_context) ? EFX_FILTER_FLAG_RX_RSS : 0;
53375337

53385338
efx_filter_init_rx(&spec, EFX_FILTER_PRI_AUTO, filter_flags, 0);
53395339

0 commit comments

Comments
 (0)