Skip to content

Commit 89e0032

Browse files
committed
soc: ti: ti_sci_inta_msi: Get rid of ti_sci_inta_msi_get_virq()
Just use the core function msi_get_virq(). Signed-off-by: Thomas Gleixner <[email protected]> Tested-by: Nishanth Menon <[email protected]> Reviewed-by: Greg Kroah-Hartman <[email protected]> Reviewed-by: Jason Gunthorpe <[email protected]> Acked-by: Arnd Bergmann <[email protected]> Acked-by: Vinod Koul <[email protected]> Acked-by: Nishanth Menon <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent d86a6d4 commit 89e0032

File tree

5 files changed

+7
-24
lines changed

5 files changed

+7
-24
lines changed

drivers/dma/ti/k3-udma-private.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -168,16 +168,14 @@ int xudma_pktdma_tflow_get_irq(struct udma_dev *ud, int udma_tflow_id)
168168
{
169169
const struct udma_oes_offsets *oes = &ud->soc_data->oes;
170170

171-
return ti_sci_inta_msi_get_virq(ud->dev, udma_tflow_id +
172-
oes->pktdma_tchan_flow);
171+
return msi_get_virq(ud->dev, udma_tflow_id + oes->pktdma_tchan_flow);
173172
}
174173
EXPORT_SYMBOL(xudma_pktdma_tflow_get_irq);
175174

176175
int xudma_pktdma_rflow_get_irq(struct udma_dev *ud, int udma_rflow_id)
177176
{
178177
const struct udma_oes_offsets *oes = &ud->soc_data->oes;
179178

180-
return ti_sci_inta_msi_get_virq(ud->dev, udma_rflow_id +
181-
oes->pktdma_rchan_flow);
179+
return msi_get_virq(ud->dev, udma_rflow_id + oes->pktdma_rchan_flow);
182180
}
183181
EXPORT_SYMBOL(xudma_pktdma_rflow_get_irq);

drivers/dma/ti/k3-udma.c

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2313,8 +2313,7 @@ static int udma_alloc_chan_resources(struct dma_chan *chan)
23132313

23142314
/* Event from UDMA (TR events) only needed for slave TR mode channels */
23152315
if (is_slave_direction(uc->config.dir) && !uc->config.pkt_mode) {
2316-
uc->irq_num_udma = ti_sci_inta_msi_get_virq(ud->dev,
2317-
irq_udma_idx);
2316+
uc->irq_num_udma = msi_get_virq(ud->dev, irq_udma_idx);
23182317
if (uc->irq_num_udma <= 0) {
23192318
dev_err(ud->dev, "Failed to get udma irq (index: %u)\n",
23202319
irq_udma_idx);
@@ -2486,7 +2485,7 @@ static int bcdma_alloc_chan_resources(struct dma_chan *chan)
24862485
uc->psil_paired = true;
24872486
}
24882487

2489-
uc->irq_num_ring = ti_sci_inta_msi_get_virq(ud->dev, irq_ring_idx);
2488+
uc->irq_num_ring = msi_get_virq(ud->dev, irq_ring_idx);
24902489
if (uc->irq_num_ring <= 0) {
24912490
dev_err(ud->dev, "Failed to get ring irq (index: %u)\n",
24922491
irq_ring_idx);
@@ -2503,8 +2502,7 @@ static int bcdma_alloc_chan_resources(struct dma_chan *chan)
25032502

25042503
/* Event from BCDMA (TR events) only needed for slave channels */
25052504
if (is_slave_direction(uc->config.dir)) {
2506-
uc->irq_num_udma = ti_sci_inta_msi_get_virq(ud->dev,
2507-
irq_udma_idx);
2505+
uc->irq_num_udma = msi_get_virq(ud->dev, irq_udma_idx);
25082506
if (uc->irq_num_udma <= 0) {
25092507
dev_err(ud->dev, "Failed to get bcdma irq (index: %u)\n",
25102508
irq_udma_idx);
@@ -2672,7 +2670,7 @@ static int pktdma_alloc_chan_resources(struct dma_chan *chan)
26722670

26732671
uc->psil_paired = true;
26742672

2675-
uc->irq_num_ring = ti_sci_inta_msi_get_virq(ud->dev, irq_ring_idx);
2673+
uc->irq_num_ring = msi_get_virq(ud->dev, irq_ring_idx);
26762674
if (uc->irq_num_ring <= 0) {
26772675
dev_err(ud->dev, "Failed to get ring irq (index: %u)\n",
26782676
irq_ring_idx);

drivers/soc/ti/k3-ringacc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -647,7 +647,7 @@ int k3_ringacc_get_ring_irq_num(struct k3_ring *ring)
647647
if (!ring)
648648
return -EINVAL;
649649

650-
irq_num = ti_sci_inta_msi_get_virq(ring->parent->dev, ring->ring_id);
650+
irq_num = msi_get_virq(ring->parent->dev, ring->ring_id);
651651
if (irq_num <= 0)
652652
irq_num = -EINVAL;
653653
return irq_num;

drivers/soc/ti/ti_sci_inta_msi.c

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -148,15 +148,3 @@ void ti_sci_inta_msi_domain_free_irqs(struct device *dev)
148148
ti_sci_inta_msi_free_descs(dev);
149149
}
150150
EXPORT_SYMBOL_GPL(ti_sci_inta_msi_domain_free_irqs);
151-
152-
unsigned int ti_sci_inta_msi_get_virq(struct device *dev, u32 dev_index)
153-
{
154-
struct msi_desc *desc;
155-
156-
for_each_msi_entry(desc, dev)
157-
if (desc->msi_index == dev_index)
158-
return desc->irq;
159-
160-
return -ENODEV;
161-
}
162-
EXPORT_SYMBOL_GPL(ti_sci_inta_msi_get_virq);

include/linux/soc/ti/ti_sci_inta_msi.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,5 @@ struct irq_domain
1818
struct irq_domain *parent);
1919
int ti_sci_inta_msi_domain_alloc_irqs(struct device *dev,
2020
struct ti_sci_resource *res);
21-
unsigned int ti_sci_inta_msi_get_virq(struct device *dev, u32 index);
2221
void ti_sci_inta_msi_domain_free_irqs(struct device *dev);
2322
#endif /* __INCLUDE_LINUX_IRQCHIP_TI_SCI_INTA_H */

0 commit comments

Comments
 (0)