ppp: Remove redundant BUG_ON() check in ppp_pernet

ISCAS-Vulab · davem330 · commit 8a3f44a0bb76 · 2019-12-27T16:30:52.000-08:00
Passing NULL to ppp_pernet causes a crash via BUG_ON.
Dereferencing net in net_generic() also has the same effect.
This patch removes the redundant BUG_ON check on the same parameter.

Signed-off-by: Xu Wang &lt;vulab@iscas.ac.cn&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/ppp/ppp_generic.c b/drivers/net/ppp/ppp_generic.c
@@ -296,8 +296,6 @@ static struct class *ppp_class;
 /* per net-namespace data */
 static inline struct ppp_net *ppp_pernet(struct net *net)
 {
-	BUG_ON(!net);
-
 	return net_generic(net, ppp_net_id);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -296,8 +296,6 @@ static struct class *ppp_class;`
`296`	`296`	`/* per net-namespace data */`
`297`	`297`	`static inline struct ppp_net ppp_pernet(struct net net)`
`298`	`298`	`{`
`299`		`- BUG_ON(!net);`
`300`		`-`
`301`	`299`	`return net_generic(net, ppp_net_id);`
`302`	`300`	`}`
`303`	`301`